Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Side by Side Diff: chrome/browser/sync/test/integration/sync_test.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/test/integration/sync_test.h" 5 #include "chrome/browser/sync/test/integration/sync_test.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 std::string path = "chromiumsync/transienterror"; 619 std::string path = "chromiumsync/transienterror";
620 ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path)); 620 ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
621 ASSERT_EQ("Transient error", 621 ASSERT_EQ("Transient error",
622 UTF16ToASCII(browser()->GetSelectedTabContents()->GetTitle())); 622 UTF16ToASCII(browser()->GetSelectedTabContents()->GetTitle()));
623 } 623 }
624 624
625 namespace { 625 namespace {
626 626
627 sync_pb::ClientToServerResponse::ErrorType 627 sync_pb::ClientToServerResponse::ErrorType
628 GetClientToServerResponseErrorType( 628 GetClientToServerResponseErrorType(
629 browser_sync::SyncProtocolErrorType error) { 629 browser_sync::SyncOperationResultType error) {
630 switch (error) { 630 switch (error) {
631 case browser_sync::SYNC_SUCCESS: 631 case browser_sync::OPERATION_SUCCESS:
632 return sync_pb::ClientToServerResponse::SUCCESS; 632 return sync_pb::ClientToServerResponse::SUCCESS;
633 case browser_sync::NOT_MY_BIRTHDAY: 633 case browser_sync::NOT_MY_BIRTHDAY:
634 return sync_pb::ClientToServerResponse::NOT_MY_BIRTHDAY; 634 return sync_pb::ClientToServerResponse::NOT_MY_BIRTHDAY;
635 case browser_sync::THROTTLED: 635 case browser_sync::THROTTLED:
636 return sync_pb::ClientToServerResponse::THROTTLED; 636 return sync_pb::ClientToServerResponse::THROTTLED;
637 case browser_sync::CLEAR_PENDING: 637 case browser_sync::CLEAR_PENDING:
638 return sync_pb::ClientToServerResponse::CLEAR_PENDING; 638 return sync_pb::ClientToServerResponse::CLEAR_PENDING;
639 case browser_sync::TRANSIENT_ERROR: 639 case browser_sync::TRANSIENT_ERROR:
640 return sync_pb::ClientToServerResponse::TRANSIENT_ERROR; 640 return sync_pb::ClientToServerResponse::TRANSIENT_ERROR;
641 case browser_sync::MIGRATION_DONE: 641 case browser_sync::MIGRATION_DONE:
(...skipping 23 matching lines...) Expand all
665 case browser_sync::UNKNOWN_ACTION: 665 case browser_sync::UNKNOWN_ACTION:
666 return sync_pb::ClientToServerResponse::Error::UNKNOWN_ACTION; 666 return sync_pb::ClientToServerResponse::Error::UNKNOWN_ACTION;
667 default: 667 default:
668 NOTREACHED(); 668 NOTREACHED();
669 return sync_pb::ClientToServerResponse::Error::UNKNOWN_ACTION; 669 return sync_pb::ClientToServerResponse::Error::UNKNOWN_ACTION;
670 } 670 }
671 } 671 }
672 672
673 } // namespace 673 } // namespace
674 674
675 void SyncTest::TriggerSyncError(const browser_sync::SyncProtocolError& error) { 675 void SyncTest::TriggerSyncError(const browser_sync::SyncOperationResult& error) {
676 ASSERT_TRUE(ServerSupportsErrorTriggering()); 676 ASSERT_TRUE(ServerSupportsErrorTriggering());
677 std::string path = "chromiumsync/error"; 677 std::string path = "chromiumsync/error";
678 int error_type = 678 int error_type =
679 static_cast<int>(GetClientToServerResponseErrorType( 679 static_cast<int>(GetClientToServerResponseErrorType(
680 error.error_type)); 680 error.error_type));
681 int action = static_cast<int>(GetClientToServerResponseAction( 681 int action = static_cast<int>(GetClientToServerResponseAction(
682 error.action)); 682 error.action));
683 683
684 path.append(base::StringPrintf("?error=%d", error_type)); 684 path.append(base::StringPrintf("?error=%d", error_type));
685 path.append(base::StringPrintf("&action=%d", action)); 685 path.append(base::StringPrintf("&action=%d", action));
(...skipping 19 matching lines...) Expand all
705 const net::ProxyConfig& proxy_config) { 705 const net::ProxyConfig& proxy_config) {
706 base::WaitableEvent done(false, false); 706 base::WaitableEvent done(false, false);
707 BrowserThread::PostTask( 707 BrowserThread::PostTask(
708 BrowserThread::IO, 708 BrowserThread::IO,
709 FROM_HERE, 709 FROM_HERE,
710 new SetProxyConfigTask(&done, 710 new SetProxyConfigTask(&done,
711 context_getter, 711 context_getter,
712 proxy_config)); 712 proxy_config));
713 done.Wait(); 713 done.Wait();
714 } 714 }
OLDNEW
« no previous file with comments | « chrome/browser/sync/test/integration/sync_test.h ('k') | chrome/browser/sync/test/integration/two_client_apps_sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698