chrome/browser/sync/test/integration/single_client_passwords_sync_test.cc - Issue 7861013: Fix the false-positive detection of commit errors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sync/test/integration/single_client_passwords_sync_test.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc ('k') | chrome/browser/sync/test/integration/single_client_preferences_sync_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/password_manager/password_form_data.h"	5 #include "chrome/browser/password_manager/password_form_data.h"

6 #include "chrome/browser/sync/profile_sync_service_harness.h"	6 #include "chrome/browser/sync/profile_sync_service_harness.h"

7 #include "chrome/browser/sync/test/integration/sync_test.h"	7 #include "chrome/browser/sync/test/integration/sync_test.h"

8 #include "chrome/browser/sync/test/integration/passwords_helper.h"	8 #include "chrome/browser/sync/test/integration/passwords_helper.h"

9	9

10 using passwords_helper::AddLogin;	10 using passwords_helper::AddLogin;

(...skipping 22 matching lines...) Expand all Loading...
33 IN_PROC_BROWSER_TEST_F(SingleClientPasswordsSyncTest, Sanity) {	33 IN_PROC_BROWSER_TEST_F(SingleClientPasswordsSyncTest, Sanity) {

34 #endif	34 #endif

35 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";	35 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";

36	36

37 PasswordForm form = CreateTestPasswordForm(0);	37 PasswordForm form = CreateTestPasswordForm(0);

38 AddLogin(GetVerifierPasswordStore(), form);	38 AddLogin(GetVerifierPasswordStore(), form);

39 ASSERT_EQ(1, GetVerifierPasswordCount());	39 ASSERT_EQ(1, GetVerifierPasswordCount());

40 AddLogin(GetPasswordStore(0), form);	40 AddLogin(GetPasswordStore(0), form);

41 ASSERT_EQ(1, GetPasswordCount(0));	41 ASSERT_EQ(1, GetPasswordCount(0));

42	42

43 ASSERT_TRUE(GetClient(0)->AwaitSyncCycleCompletion("Added a login."));	43 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion("Added a login."));

44 ASSERT_TRUE(ProfileContainsSamePasswordFormsAsVerifier(0));	44 ASSERT_TRUE(ProfileContainsSamePasswordFormsAsVerifier(0));

45 ASSERT_EQ(1, GetPasswordCount(0));	45 ASSERT_EQ(1, GetPasswordCount(0));

46 }	46 }

OLD	NEW