Fix the false-positive detection of commit errors

chrome/browser/sync/protocol/sync_protocol_error.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/protocol/sync_protocol_error.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/values.h"
 
 namespace browser_sync {
 #define ENUM_CASE(x) case x: return #x; break;
 
-const char* GetSyncErrorTypeString(SyncProtocolErrorType type) {
+const char* GetSyncErrorTypeString(SyncOperationResultType type) {
   switch (type) {
-    ENUM_CASE(SYNC_SUCCESS);
+    ENUM_CASE(OPERATION_SUCCESS);
+    ENUM_CASE(DIRECTORY_LOOKUP_FAILED);
+    ENUM_CASE(NETWORK_CONNECTION_UNAVAILABLE);
+    ENUM_CASE(NETWORK_IO_ERROR);
+    ENUM_CASE(SYNC_SERVER_ERROR);
+    ENUM_CASE(SYNC_AUTH_ERROR);
     ENUM_CASE(NOT_MY_BIRTHDAY);
     ENUM_CASE(THROTTLED);
     ENUM_CASE(CLEAR_PENDING);
     ENUM_CASE(TRANSIENT_ERROR);
     ENUM_CASE(NON_RETRIABLE_ERROR);
     ENUM_CASE(MIGRATION_DONE);
     ENUM_CASE(INVALID_CREDENTIAL);
+    ENUM_CASE(INVALID);
     ENUM_CASE(UNKNOWN_ERROR);
   }
   NOTREACHED();
   return "";
 }
 
 const char* GetClientActionString(ClientAction action) {
   switch (action) {
     ENUM_CASE(UPGRADE_CLIENT);
     ENUM_CASE(CLEAR_USER_DATA_AND_RESYNC);
     ENUM_CASE(ENABLE_SYNC_ON_ACCOUNT);
     ENUM_CASE(STOP_AND_RESTART_SYNC);
     ENUM_CASE(DISABLE_SYNC_ON_CLIENT);
     ENUM_CASE(UNKNOWN_ACTION);
   }
   NOTREACHED();
   return "";
 }
 
-SyncProtocolError::SyncProtocolError()
-    : error_type(UNKNOWN_ERROR),
+SyncOperationResult::SyncOperationResult()
+    : error_type(INVALID),
       action(UNKNOWN_ACTION) {
 }
 
-SyncProtocolError::~SyncProtocolError() {
+SyncOperationResult::~SyncOperationResult() {
 }
 
-DictionaryValue* SyncProtocolError::ToValue() const {
+DictionaryValue* SyncOperationResult::ToValue() const {
   DictionaryValue* value = new DictionaryValue();
   value->SetString("ErrorType",
                    GetSyncErrorTypeString(error_type));
   value->SetString("ErrorDescription", error_description);
   value->SetString("url", url);
   value->SetString("action", GetClientActionString(action));
   return value;
 }
 
 }  // namespace browser_sync