Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: chrome/browser/sync/profile_sync_service.h

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_ 5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_ 6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 virtual void OnPassphraseRequired( 204 virtual void OnPassphraseRequired(
205 sync_api::PassphraseRequiredReason reason) OVERRIDE; 205 sync_api::PassphraseRequiredReason reason) OVERRIDE;
206 virtual void OnPassphraseAccepted() OVERRIDE; 206 virtual void OnPassphraseAccepted() OVERRIDE;
207 virtual void OnEncryptionComplete( 207 virtual void OnEncryptionComplete(
208 const syncable::ModelTypeSet& encrypted_types) OVERRIDE; 208 const syncable::ModelTypeSet& encrypted_types) OVERRIDE;
209 virtual void OnMigrationNeededForTypes( 209 virtual void OnMigrationNeededForTypes(
210 const syncable::ModelTypeSet& types) OVERRIDE; 210 const syncable::ModelTypeSet& types) OVERRIDE;
211 virtual void OnDataTypesChanged( 211 virtual void OnDataTypesChanged(
212 const syncable::ModelTypeSet& to_add) OVERRIDE; 212 const syncable::ModelTypeSet& to_add) OVERRIDE;
213 virtual void OnActionableError( 213 virtual void OnActionableError(
214 const browser_sync::SyncProtocolError& error) OVERRIDE; 214 const browser_sync::SyncOperationResult& error) OVERRIDE;
215 215
216 void OnClearServerDataTimeout(); 216 void OnClearServerDataTimeout();
217 217
218 // Called when a user enters credentials through UI. 218 // Called when a user enters credentials through UI.
219 virtual void OnUserSubmittedAuth(const std::string& username, 219 virtual void OnUserSubmittedAuth(const std::string& username,
220 const std::string& password, 220 const std::string& password,
221 const std::string& captcha, 221 const std::string& captcha,
222 const std::string& access_code); 222 const std::string& access_code);
223 223
224 // Called when a user enters credentials through UI. 224 // Called when a user enters credentials through UI.
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 // If true, we want to automatically start sync signin whenever we have 663 // If true, we want to automatically start sync signin whenever we have
664 // credentials (user doesn't need to go through the startup flow). This is 664 // credentials (user doesn't need to go through the startup flow). This is
665 // typically enabled on platforms (like ChromeOS) that have their own 665 // typically enabled on platforms (like ChromeOS) that have their own
666 // distinct signin flow. 666 // distinct signin flow.
667 bool auto_start_enabled_; 667 bool auto_start_enabled_;
668 668
669 scoped_ptr<browser_sync::BackendMigrator> migrator_; 669 scoped_ptr<browser_sync::BackendMigrator> migrator_;
670 670
671 // This is the last |SyncProtocolError| we received from the server that had 671 // This is the last |SyncProtocolError| we received from the server that had
672 // an action set on it. 672 // an action set on it.
673 browser_sync::SyncProtocolError last_actionable_error_; 673 browser_sync::SyncOperationResult last_actionable_error_; // FIXME: please tel l me this isn't used...
674 674
675 // This is used to show sync errors in the wrench menu. 675 // This is used to show sync errors in the wrench menu.
676 scoped_ptr<SyncGlobalError> sync_global_error_; 676 scoped_ptr<SyncGlobalError> sync_global_error_;
677 677
678 DISALLOW_COPY_AND_ASSIGN(ProfileSyncService); 678 DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
679 }; 679 };
680 680
681 bool ShouldShowActionOnUI( 681 bool ShouldShowActionOnUI(
682 const browser_sync::SyncProtocolError& error); 682 const browser_sync::SyncOperationResult& result);
683 683
684 684
685 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_ 685 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/js/js_sync_manager_observer_unittest.cc ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698