Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 786063002: Revert of Implement HasPermission() method in PermissionService. (Closed)

Created:
6 years ago by Ryan Sleevi
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Miguel Garcia
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement HasPermission() method in PermissionService. (patchset #24 id:480001 of https://codereview.chromium.org/750633003/) Reason for revert: Causes Android Builder (dbg) to fail compile. http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/70387/steps/compile/logs/stdio#error1 FAILED: /b/build/goma/gomacc /b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/android_webview/native/webview_native.aw_contents_statics.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_BROWSER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA -DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_SUPERVISED_USERS=1 -DVIDEO_HOLE=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DMOJO_USE_SYSTEM_IMPL -DPOSIX_AVOID_MMAP -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_IGNORE_GPU_LAYER_HOISTING -DSK_BUILD_FOR_ANDROID -DSK_USE_POSIX_THREADS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DANDROID -D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/angle -I../../third_party/WebKit -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/boringssl/src/include -Igen/android_webview -fstack-protector --param=ssp-buffer-size=4 -Werror -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -march=armv7-a -mtune=generic-armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp -mthumb -fno-tree-sra -fno-caller-saves -Wno-psabi -mthumb-interwork -ffunction-sections -funwind-tables -g -fstack-protector -fno-short-enums -finline-limit=64 -Wa,--noexecstack --sysroot=/b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm -isystem/b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport -Os -g -gdwarf-4 -fdata-sections -ffunction-sections -fomit-frame-pointer -funwind-tables -g1 -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-abi -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -c ../../android_webview/native/aw_contents_statics.cc -o obj/android_webview/native/webview_native.aw_contents_statics.o In file included from ../../android_webview/browser/aw_browser_context.h:18:0, from ../../android_webview/native/aw_contents_statics.cc:7: ../../content/public/browser/content_browser_client.h:23:59: fatalerror: content/public/common/permission_status.mojom.h: No such file or directory #include "content/public/common/permission_status.mojom.h" Original issue's description: > Implement HasPermission() method in PermissionService. > > This patch implements the HasPermission() method in the mojo PermissionService. > This methiod will be required for the Permissions API, see > https://w3c.github.io/permissions/ > > BUG=430238 > > Committed: https://crrev.com/277b23d74855b51ebe67ae0da7cd9e0b053044cf > Cr-Commit-Position: refs/heads/master@{#307302} TBR=mlamouri@chromium.org,qsr@chromium.org,blundell@chromium.org,tsepez@chromium.org,avi@chromium.org,timvolodine@chromium.org NOTREECHECKS=true NOTRY=true BUG=430238 Committed: https://crrev.com/f0c72398c01cc4dd9eca00b5f5d215df4ef54b4b Cr-Commit-Position: refs/heads/master@{#307304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -157 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -61 lines 0 comments Download
D content/browser/permissions/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/permissions/permission_service_context.h View 4 chunks +0 lines, -6 lines 0 comments Download
M content/browser/permissions/permission_service_context.cc View 3 chunks +1 line, -23 lines 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 1 chunk +1 line, -10 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/permission_service.mojom View 1 chunk +5 lines, -1 line 0 comments Download
M content/content.gyp View 7 chunks +9 lines, -16 lines 0 comments Download
M content/content_app.gypi View 2 chunks +5 lines, -2 lines 0 comments Download
M content/content_common_mojo_bindings.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/common/permission_status.mojom View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
Created Revert of Implement HasPermission() method in PermissionService.
6 years ago (2014-12-08 19:40:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786063002/1
6 years ago (2014-12-08 19:41:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 19:42:43 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-08 19:43:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0c72398c01cc4dd9eca00b5f5d215df4ef54b4b
Cr-Commit-Position: refs/heads/master@{#307304}

Powered by Google App Engine
This is Rietveld 408576698