chrome/browser/resources/about_version.html - Issue 786023002: Remove hard-coded font families in WebUI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/about_version.html

Issue 786023002: Remove hard-coded font families in WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the presubmit warnings. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2	2

3 <!--	3 <!--

4 about:version template page	4 about:version template page

5 -->	5 -->

6	6

7 <html id="t" i18n-values="dir:textdirection;">	7 <html id="t" i18n-values="dir:textdirection;">

8 <head>	8 <head>

9 <meta charset="utf-8">	9 <meta charset="utf-8">

10 <title i18n-content="title"></title>	10 <title i18n-content="title"></title>

	11 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
	Dan Beam 2014/12/17 22:56:53 fyi: this changed the font size on about:version s fyi: this changed the font size on about:version significantly... we should consider adding a specific override if this isn't OK jungshik at Google 2014/12/17 23:46:49 hmm.. I guess it's about 80% of the previous size. Show quoted text On 2014/12/17 22:56:53, Dan Beam wrote: > fyi: this changed the font size on about:version significantly... we should > consider adding a specific override if this isn't OK hmm.. I guess it's about 80% of the previous size. about:version relied on the default font size for sans-serif (16px) and monospace (13px). I agree that we should consider explicitly setting the font size in about_version.css. Perhaps, I'll just do it now to minimize the difference due to this CL because xdai is ooo.
11 <if expr="is_android">	12 <if expr="is_android">

12 <meta name="viewport" content="width=device-width">	13 <meta name="viewport" content="width=device-width">

13 </if>	14 </if>

14 <link rel="stylesheet" href="chrome://version/about_version.css">	15 <link rel="stylesheet" href="chrome://version/about_version.css">

15 <if expr="is_android">	16 <if expr="is_android">

16 <link rel="stylesheet" href="about_version_android.css">	17 <link rel="stylesheet" href="about_version_android.css">

17 </if>	18 </if>

18 <script src="chrome://resources/js/cr.js"></script>	19 <script src="chrome://resources/js/cr.js"></script>

19 <script src="chrome://resources/js/load_time_data.js"></script>	20 <script src="chrome://resources/js/load_time_data.js"></script>

20 <script src="chrome://resources/js/parse_html_subset.js"></script>	21 <script src="chrome://resources/js/parse_html_subset.js"></script>

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
97 <tr id="build-id-section">	98 <tr id="build-id-section">

98 <td class="label" i18n-content="build_id_name"></td>	99 <td class="label" i18n-content="build_id_name"></td>

99 <td class="version" i18n-content="build_id"></td>	100 <td class="version" i18n-content="build_id"></td>

100 </tr>	101 </tr>

101 </if>	102 </if>

102 </table>	103 </table>

103 </div>	104 </div>

104 <script src="chrome://resources/js/i18n_template2.js"></script>	105 <script src="chrome://resources/js/i18n_template2.js"></script>

105 </body>	106 </body>

106 </html>	107 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/resources/about_version.css ('k') | chrome/browser/resources/about_voicesearch.html » ('j') | no next file with comments »