chrome/browser/resources/notification_2line.html - Issue 786023002: Remove hard-coded font families in WebUI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/notification_2line.html

Issue 786023002: Remove hard-coded font families in WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: The First Version. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/net_internals/index.html ('K') | « chrome/browser/resources/notification_1line.html ('k') | chrome/browser/resources/notification_icon.html » ('j') | chrome/browser/resources/notification_icon.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>$1</title>	5 <title>$1</title>

	6 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

6 <style type="text/css">	7 <style type="text/css">

7 #title {	8 #title {

8 font-weight: bold;	9 font-weight: bold;

9 font-size: 13px;	10 font-size: 13px;
	Dan Beam 2014/12/10 19:49:25 i guess this should stay... i guess this should stay...
10 font-family: helvetica, arial, sans-serif;

11 }	11 }

12 #description {	12 #description {

13 font-family: helvetica, arial, sans-serif;

14 font-size: 13px;	13 font-size: 13px;

15 }	14 }
	Dan Beam 2014/12/10 19:49:25 nit: #title, #description { font-size: 13 nit: #title, #description { font-size: 13px; } #title { font-weight: bold; } xdai1 2014/12/11 02:59:22 Done. Show quoted text On 2014/12/10 19:49:25, Dan Beam wrote: > nit: > > #title, > #description { > font-size: 13px; > } > > #title { > font-weight: bold; > } Done.
16 </style>	15 </style>

17 </head>	16 </head>

18 <body dir="$3">	17 <body dir="$3">
	Dan Beam 2014/12/10 19:49:25 dir="$3" should probably be on <html> dir="$3" should probably be on <html> jungshik at Google 2014/12/10 20:46:57 I wonder whether the direction for 'notification' Show quoted text On 2014/12/10 19:49:25, Dan Beam wrote: > dir="$3" should probably be on <html> I wonder whether the direction for 'notification' is completely determined by the UI language's direction or we want to set the direction based on the actual content (+ the ui language direction). If it's the former, we have to go to the corresponding C++ file and change it not to populate $3 here because the direction (purely determined by the UI lang's direction) is already set in text_default.css. BTW, I couldn't find any reference to IDR_NOTIFICATION_2LINE_HTML.. H Anyway, in this CL, we can leave it alone (aside from moving to html). xdai1 2014/12/11 02:59:23 Moved to html. Show quoted text On 2014/12/10 19:49:25, Dan Beam wrote: > dir="$3" should probably be on <html> Moved to html.
19 <div id="title">$1</div>	18 <div id="title">$1</div>

20 <div id="description">$2</div>	19 <div id="description">$2</div>

21 </body>	20 </body>

22 </html>	21 </html>

OLD	NEW