chrome/browser/resources/about_credits.tmpl - Issue 786023002: Remove hard-coded font families in WebUI.

Side by Side Diff: chrome/browser/resources/about_credits.tmpl

Issue 786023002: Remove hard-coded font families in WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: The First Version. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>Credits</title>	5 <title>Credits</title>

	6 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

6 <style>	7 <style>

7 body {	8 body {

8 font-family:Helvetica,Arial,sans-serif;

9 background-color:white;	9 background-color:white;

10 font-size:84%;
jungshik at Google 2014/12/10 07:57:57 Really sorry that I told you to remove font-size f Really sorry that I told you to remove font-size for body. I have a second thought and believe that we should keep font-size for body for now in this file and other files. xdai1 2014/12/11 02:59:21 Done. Show quoted text On 2014/12/10 07:57:57, Jungshik Shin wrote: > Really sorry that I told you to remove font-size for body. I have a second > thought and believe that we should keep font-size for body for now in this file > and other files. Done. Dan Beam 2014/12/11 19:15:28 why? this will cause chrome:// pages to continue Show quoted text On 2014/12/10 07:57:57, Jungshik Shin wrote: > Really sorry that I told you to remove font-size for body. I have a second > thought and believe that we should keep font-size for body for now in this file > and other files. why? this will cause chrome:// pages to continue to be inconsistent and flicker (as the font-size will be loaded with JS in some cases, and that'll happen after the first frame is rendered [as of recently]). Dan Beam 2014/12/11 19:21:14 re: flicker -- see https://code.google.com/p/chrom Show quoted text On 2014/12/11 19:15:28, Dan Beam wrote: > On 2014/12/10 07:57:57, Jungshik Shin wrote: > > Really sorry that I told you to remove font-size for body. I have a second > > thought and believe that we should keep font-size for body for now in this > file > > and other files. > > why? this will cause chrome:// pages to continue to be inconsistent and flicker > (as the font-size will be loaded with JS in some cases, and that'll happen > after the first frame is rendered [as of recently]). re: flicker -- see https://code.google.com/p/chromium/issues/detail?id=434974
11 max-width:1020px;	10 max-width:1020px;

12 }	11 }

13 .page-title {	12 .page-title {

14 font-size:164%;	13 font-size:164%;

15 font-weight:bold;	14 font-weight:bold;

16 }	15 }

17 .product {	16 .product {

18 background-color:#c3d9ff;	17 background-color:#c3d9ff;

19 overflow:auto;	18 overflow:auto;

20 padding:2px;	19 padding:2px;

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67 <body>	66 <body>

68 <span class="page-title" style="float:left;">Credits</span>	67 <span class="page-title" style="float:left;">Credits</span>

69 <a id="print-link" href="#" style="float:right;">Print</a>	68 <a id="print-link" href="#" style="float:right;">Print</a>

70 <div style="clear:both; overflow:auto;"><!-- Chromium <3s the following projects -->	69 <div style="clear:both; overflow:auto;"><!-- Chromium <3s the following projects -->

71 {{entries}}	70 {{entries}}

72 </div>	71 </div>

73 <script src="chrome://credits/credits.js"></script>	72 <script src="chrome://credits/credits.js"></script>

74 <script src="chrome://credits/keyboard_utils.js"></script>	73 <script src="chrome://credits/keyboard_utils.js"></script>

75 </body>	74 </body>

76 </html>	75 </html>

OLD	NEW