Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/d8.h

Issue 7860016: Fix v8 shared library build by wrapping SourceGroup dtor into an ifndef V8_SHARED check. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/d8.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.h
diff --git a/src/d8.h b/src/d8.h
index c0ef670920e49c9533d6686fc3be2e9beb1fb4bb..e0fbe1883ad21dfc58abcb691e77f693588d4a0a 100644
--- a/src/d8.h
+++ b/src/d8.h
@@ -127,7 +127,9 @@ class SourceGroup {
begin_offset_(0),
end_offset_(0) {}
+#ifndef V8_SHARED
~SourceGroup();
+#endif
void Begin(char** argv, int offset) {
argv_ = const_cast<const char**>(argv);
« no previous file with comments | « no previous file | src/d8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698