Have FakeGCMProfileService return different registration IDs each time

Have FakeGCMProfileService return different registration IDs each time

This will be necessary for testing that the Push API code properly
persists push registrations to disk.

The slightly odd 1000 * (sender_ids.size() - 1) means that existing tests that only register once and pass in a single sender ID are unchanged.

BUG=429212
Committed: https://crrev.com/29022c572fbd857e94f9e1d1eb5c19ed285863a2
Cr-Commit-Position: refs/heads/master@{#307906}

[johnme, 2014-12-08 15:41:56]

johnme@chromium.org changed reviewers:
+ fgorski@chromium.org

[Avi (use Gerrit), 2014-12-08 19:08:43]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2014-12-08 19:08:43]

LGTM if you explain in the code.

https://codereview.chromium.org/785983002/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/fake_gcm_profile_service.cc (right):

https://codereview.chromium.org/785983002/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/fake_gcm_profile_service.cc:134: +
(++registration_count_)),
Put your explanation for this directly into the code as a comment.

[johnme, 2014-12-08 20:30:28]

Added comment explaining fake registration ID generation at Avi's suggestion.

https://codereview.chromium.org/785983002/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/fake_gcm_profile_service.cc (right):

https://codereview.chromium.org/785983002/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/fake_gcm_profile_service.cc:134: +
(++registration_count_)),
On 2014/12/08 19:08:43, Avi wrote:
> Put your explanation for this directly into the code as a comment.

Done.

[fgorski, 2014-12-08 22:36:59]

lgtm

Could you flip the created ID per suggestion?

https://codereview.chromium.org/785983002/diff/40001/chrome/browser/services/...
File chrome/browser/services/gcm/fake_gcm_profile_service.cc (right):

https://codereview.chromium.org/785983002/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/fake_gcm_profile_service.cc:135: int registration_id
= ++registration_count_ + 1000 * (sender_ids.size() - 1);
why not?
int registration_id = registration_count_ * 1000 + sender_ids.size();
++registration_count_;

I think it is ok to rebase failing tests in that case, but most of them should
stay the same.

[johnme, 2014-12-10 14:12:53]

https://codereview.chromium.org/785983002/diff/40001/chrome/browser/services/...
File chrome/browser/services/gcm/fake_gcm_profile_service.cc (right):

https://codereview.chromium.org/785983002/diff/40001/chrome/browser/services/...
chrome/browser/services/gcm/fake_gcm_profile_service.cc:135: int registration_id
= ++registration_count_ + 1000 * (sender_ids.size() - 1);
On 2014/12/08 22:36:59, fgorski wrote:
> why not?
> int registration_id = registration_count_ * 1000 + sender_ids.size();
> ++registration_count_;
> 
> I think it is ok to rebase failing tests in that case, but most of them should
> stay the same.

Ok, I've changed it to a simpler format:
    sender_ids.size() + "-" + (registration_count_++)
and updated the tests.

[fgorski, 2014-12-10 17:34:56]

still lg, with a nit and a question.

https://codereview.chromium.org/785983002/diff/60001/chrome/browser/services/...
File chrome/browser/services/gcm/fake_gcm_profile_service.cc (right):

https://codereview.chromium.org/785983002/diff/60001/chrome/browser/services/...
chrome/browser/services/gcm/fake_gcm_profile_service.cc:135: std::string
registration_id = base::StringPrintf("%" PRIuS "-%d",
huh? What is that thing?

https://codereview.chromium.org/785983002/diff/60001/chrome/browser/services/...
chrome/browser/services/gcm/fake_gcm_profile_service.cc:142:
custom_driver->OnRegisterFinished(app_id, registration_id,
put all of the arguments on a single line below the method call (indent by 4)

[johnme, 2014-12-11 14:25:06]

https://codereview.chromium.org/785983002/diff/60001/chrome/browser/services/...
File chrome/browser/services/gcm/fake_gcm_profile_service.cc (right):

https://codereview.chromium.org/785983002/diff/60001/chrome/browser/services/...
chrome/browser/services/gcm/fake_gcm_profile_service.cc:135: std::string
registration_id = base::StringPrintf("%" PRIuS "-%d",
On 2014/12/10 17:34:55, fgorski wrote:
> huh? What is that thing?

It's how you printf a size_t. See:

https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#64-bit_Porta...

and

https://code.google.com/p/chromium/codesearch#chromium/src/base/format_macros...

https://codereview.chromium.org/785983002/diff/60001/chrome/browser/services/...
chrome/browser/services/gcm/fake_gcm_profile_service.cc:142:
custom_driver->OnRegisterFinished(app_id, registration_id,
On 2014/12/10 17:34:55, fgorski wrote:
> put all of the arguments on a single line below the method call (indent by 4)

Done.

[johnme, 2014-12-11 14:25:11]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2014-12-11 14:25:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/785983002/80001

[johnme, 2014-12-11 14:25:28]

Thanks for the re-review btw :)

[commit-bot: I haz the power, 2014-12-11 16:26:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-12-11 16:27:20]

Patchset 5 (id:??) landed as
https://crrev.com/29022c572fbd857e94f9e1d1eb5c19ed285863a2
Cr-Commit-Position: refs/heads/master@{#307906}