Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 785943002: ARIA state/property aria-autocomplete should expose IA2_STATE_SUPPORTS_AUTOCOMPLETION. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ARIA state/property aria-autocomplete should expose IA2_STATE_SUPPORTS_AUTOCOMPLETION. According to specs http://rawgit.com/w3c/aria/master/core-aam/core-aam.html aria-autocomplete {"inline", "list","both"} set IA2_STATE_SUPPORTS_AUTOCOMPLETION. aria-autocomplete {"none"} Not Mapped Also, expose object attribute autocomplete: <value>. This CL depends on https://codereview.chromium.org/779513007/ BUG=169559, 169563 Committed: https://crrev.com/634dc714772518f79dd0ea145bd0433072ec74b5 Cr-Commit-Position: refs/heads/master@{#308714}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : updating expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria-autocomplete.html View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria-autocomplete-expected-android.txt View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria-autocomplete-expected-win.txt View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
shreeramk
@aboxhall: please review. Thanks!!
6 years ago (2014-12-12 10:46:45 UTC) #2
aboxhall
lgtm
6 years ago (2014-12-12 17:38:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785943002/40001
6 years ago (2014-12-12 19:00:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30110)
6 years ago (2014-12-12 19:10:32 UTC) #7
shreeramk
On 2014/12/12 19:10:32, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-16 07:44:26 UTC) #8
dmazzoni
lgtm
6 years ago (2014-12-17 01:00:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785943002/40001
6 years ago (2014-12-17 01:01:57 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-17 01:29:04 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-17 01:29:49 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/634dc714772518f79dd0ea145bd0433072ec74b5
Cr-Commit-Position: refs/heads/master@{#308714}

Powered by Google App Engine
This is Rietveld 408576698