Issue 785933003: change SkPoint::setLength to set itself to (0,0) if it starting length is degenerate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 785933003: change SkPoint::setLength to set itself to (0,0) if it starting length is degenerate (Closed)

Created:
6 years ago by reed1

Modified:
6 years ago

Reviewers:
caryclark

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

change SkPoint::setLength to set itself to (0,0) if it starting length is degenerate. BUG=skia:3203 TBR=caryclark Committed: https://skia.googlesource.com/skia/+/a8b326c01a92e7f331c2c5dcf75cd7ce7a99ce73

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -15 lines)			Patch
M	include/core/SkPoint.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/core/SkPath.cpp	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/core/SkPoint.cpp	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/PointTest.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (2 generated)

reed1

will create a separate CL to try to improve our tolerance (maybe down to 0). ...

6 years ago (2014-12-08 22:25:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785933003/20001

6 years ago (2014-12-09 19:38:26 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-09 19:50:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a8b326c01a92e7f331c2c5dcf75cd7ce7a99ce73