Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 785913003: Remove devtools_instrumentation::kRasterTask in favor of frame viewer's one (Closed)

Created:
6 years ago by caseq
Modified:
6 years ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, cc-bugs_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove devtools_instrumentation::kRasterTask in favor of frame viewer's one This removes RasterTask emitted through devtools instrumentation and adds disabled-by-default-devtools.timeline to categories emitted with frame_viewer_instrumentation classes (frame viewer's event has more details). BUG= Committed: https://crrev.com/cb0da5a15865b158e35c8ac9530355cd71d1e5dd Cr-Commit-Position: refs/heads/master@{#308573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M cc/debug/devtools_instrumentation.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/frame_viewer_instrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
caseq
Looks like we don't need both frame viewer's and devtools events and the former has ...
6 years ago (2014-12-08 15:43:40 UTC) #2
danakj
LGTM
6 years ago (2014-12-08 16:22:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785913003/1
6 years ago (2014-12-08 16:23:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/12432)
6 years ago (2014-12-08 17:18:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785913003/1
6 years ago (2014-12-16 12:59:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 12:59:54 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-16 13:00:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb0da5a15865b158e35c8ac9530355cd71d1e5dd
Cr-Commit-Position: refs/heads/master@{#308573}

Powered by Google App Engine
This is Rietveld 408576698