Issue 7859018: Fix a couple of data races found by TSAN Race Verifier in VideoCaptureController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7859018: Fix a couple of data races found by TSAN Race Verifier in VideoCaptureController. (Closed)

Created:
9 years, 3 months ago by Ami GONE FROM CHROMIUM

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, Alexander Potapenko, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, jam, annacc+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), pam+watch_chromium.org, Timur Iskhodzhanov, stuartmorgan+watch_chromium.org, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix a couple of data races found by TSAN Race Verifier in VideoCaptureController. Tested by removing the suppression and verifying that this command-line fails before and passes after the .cc file change: ./tools/valgrind/chrome_tests.sh --build_dir=ninja/Debug --test content --tool tsan_rv --gtest_filter=VideoCaptureHostTest.StartCaptureErrorStop BUG=86507 TEST=see above Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100446

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
	M	content/browser/renderer_host/media/video_capture_controller.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
	M	tools/valgrind/tsan/suppressions.txt	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 100446

Expand Messages | Collapse Messages