chrome/browser/extensions/extension_webnavigation_apitest.cc - Issue 7859014: Refactor ExtensionApiTest.WebNavigationEvents* to not rely on window.setTimeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webnavigation_apitest.cc

Issue 7859014: Refactor ExtensionApiTest.WebNavigationEvents* to not rely on window.setTimeout (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/webnavigation/clientRedirect/a.html » ('j') | chrome/test/data/extensions/api_test/webnavigation/framework.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_webnavigation_apitest.cc

diff --git a/chrome/browser/extensions/extension_webnavigation_apitest.cc b/chrome/browser/extensions/extension_webnavigation_apitest.cc

index a7d2afa0abc9fadc6350abb86a2fe0df8391cb65..f7a6fa64b8df8418ec96e152e50da471e4d66cf1 100644

--- a/chrome/browser/extensions/extension_webnavigation_apitest.cc

+++ b/chrome/browser/extensions/extension_webnavigation_apitest.cc

@@ -144,14 +144,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationFailures) {

RunExtensionSubtest("webnavigation", "test_failures.html")) << message_;

}

-// Fails almost consistently on Mac only. http://crbug.com/94932

-#if defined(OS_MACOSX)

-#define MAYBE_WebNavigationUserAction FAILS_WebNavigationUserAction

-#else

-#define MAYBE_WebNavigationUserAction WebNavigationUserAction

-#endif

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_WebNavigationUserAction) {

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationUserAction) {

CommandLine::ForCurrentProcess()->AppendSwitch(

switches::kEnableExperimentalExtensionApis);