Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7859014: Refactor ExtensionApiTest.WebNavigationEvents* to not rely on window.setTimeout (Closed)

Created:
9 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Refactor ExtensionApiTest.WebNavigationEvents* to not rely on window.setTimeout BUG=70382, 94932 TEST=tests still work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100675

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+949 lines, -711 lines) Patch
M chrome/browser/extensions/extension_webnavigation_apitest.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/clientRedirect/a.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/failures/b.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/forwardBack/a.html View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/forwardBack/b.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/framework.js View 1 5 chunks +82 lines, -4 lines 1 comment Download
M chrome/test/data/extensions/api_test/webnavigation/iframe/b.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/iframe/f.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/iframe/i.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/openTab/a.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/referenceFragment/a.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/test_clientRedirect.js View 1 1 chunk +56 lines, -47 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/test_failures.js View 1 1 chunk +126 lines, -99 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/test_forwardBack.js View 1 chunk +80 lines, -66 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/test_iframe.js View 1 3 chunks +278 lines, -220 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/test_openTab.js View 1 1 chunk +154 lines, -122 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/test_referenceFragment.js View 1 1 chunk +35 lines, -29 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/test_serverRedirect.js View 1 2 chunks +29 lines, -23 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/test_simpleLoad.js View 1 1 chunk +27 lines, -22 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/test_userAction.js View 1 1 chunk +64 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
plz review
9 years, 3 months ago (2011-09-09 12:09:01 UTC) #1
Matt Perry
lgtm http://codereview.chromium.org/7859014/diff/2001/chrome/test/data/extensions/api_test/webnavigation/framework.js File chrome/test/data/extensions/api_test/webnavigation/framework.js (right): http://codereview.chromium.org/7859014/diff/2001/chrome/test/data/extensions/api_test/webnavigation/framework.js#newcode159 chrome/test/data/extensions/api_test/webnavigation/framework.js:159: function navigationOrder(prefix) { great idea!
9 years, 3 months ago (2011-09-09 19:28:15 UTC) #2
Paweł Hajdan Jr.
Excellent, LGTM.
9 years, 3 months ago (2011-09-09 22:26:25 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-12 12:13:41 UTC) #4 
Change committed as 100675

Powered by Google App Engine
This is Rietveld 408576698