Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/supervised_user/child_accounts/child_account_service.cc

Issue 785893003: Adapt Chrome OS related part of ChildAccountService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ClearUserList method updated for mock. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/child_accounts/child_account_service.cc
diff --git a/chrome/browser/supervised_user/child_accounts/child_account_service.cc b/chrome/browser/supervised_user/child_accounts/child_account_service.cc
index db64a83d0b035cadc8b675c99550848074c2abd5..8b9cda7659b27f264ea0b49800c5b47aa1f4067b 100644
--- a/chrome/browser/supervised_user/child_accounts/child_account_service.cc
+++ b/chrome/browser/supervised_user/child_accounts/child_account_service.cc
@@ -294,15 +294,15 @@ void ChildAccountService::SetIsChildAccount(bool is_child_account) {
void ChildAccountService::PropagateChildStatusToUser(bool is_child) {
#if defined(OS_CHROMEOS)
- // TODO(merkulova,treib): Figure out why this causes tests to fail.
-// user_manager::User* user =
-// chromeos::ProfileHelper::Get()->GetUserByProfile(profile_);
-// if (user) {
-// user_manager::UserManager::Get()->ChangeUserSupervisedStatus(
-// user, is_child);
-// } else {
-// LOG(WARNING) <<
-// "User instance wasn't found while setting child account flag.";
-// }
+ user_manager::User* user =
+ chromeos::ProfileHelper::Get()->GetUserByProfile(profile_);
+ if (!user) {
+ LOG(WARNING) <<
+ "User instance wasn't found while setting child account flag.";
+ } else if (user->GetType() == user_manager::USER_TYPE_REGULAR_SUPERVISED ||
Marc Treib 2014/12/08 16:59:34 Hm, I don't think we should check the user type he
Marc Treib 2014/12/10 12:42:36 This one's still not addressed.
+ user->GetType() == user_manager::USER_TYPE_REGULAR) {
+ user_manager::UserManager::Get()->ChangeUserSupervisedStatus(
+ user, is_child);
+ }
#endif
}

Powered by Google App Engine
This is Rietveld 408576698