Issue 78583002: [v8-dev] ARM: Optimize TypeofIsAndBranch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78583002: [v8-dev] ARM: Optimize TypeofIsAndBranch (Closed)

Created:
7 years, 1 month ago by m.m.capewell

Modified:
7 years ago

Reviewers:
ulan, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: Optimize TypeofIsAndBranch Optimize register constraints and code generated for TypeofIsAndBranch Lithium instruction. TEST=none BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18063

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments and rebased. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -21 lines)			Patch
M	src/arm/lithium-arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	2 chunks	+20 lines, -19 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1	1 chunk	+23 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://codereview.chromium.org/78583002/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/78583002/diff/1/src/arm/lithium-codegen-arm.cc#newcode5653 src/arm/lithium-codegen-arm.cc:5653: scratch, Maybe name the scratch "map" similar to ...

7 years, 1 month ago (2013-11-22 15:43:45 UTC) #2

m.m.capewell

7 years ago (2013-11-25 19:17:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18063 (presubmit successful).

Expand Messages | Collapse Messages