Disable subpixel positioning if DirectWrite isn't initialized

ui/gfx/render_text_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <algorithm>
 
 #include "base/format_macros.h"
 #include "base/i18n/break_iterator.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/break_list.h"
 #include "ui/gfx/canvas.h"
+#include "ui/gfx/color_utils.h"
 #include "ui/gfx/font.h"
 #include "ui/gfx/render_text_harfbuzz.h"
 
 #if defined(OS_WIN)
 #include "base/win/windows_version.h"
 #include "ui/gfx/platform_font_win.h"
 #include "ui/gfx/render_text_win.h"
 #endif
 
 #if defined(OS_LINUX) && !defined(USE_OZONE)
@@ skipping 2344 matching lines @@
   render_text.EnsureLayout();
   ASSERT_EQ(1U, render_text.runs_.size());
   EXPECT_EQ(0U, render_text.runs_[0]->CountMissingGlyphs());
 }
 #endif  // defined(OS_WIN)
 
 // Ensure that the width reported by RenderText is sufficient for drawing. Draws
 // to a canvas and checks whether any pixel beyond the width is colored.
 TEST_F(RenderTextTest, TextDoesntClip) {
   const wchar_t* kTestStrings[] = { L"Save", L"Remove", L"TEST", L"W", L"WWW" };
+  const Size kCanvasSize(300, 50);
+  const int kTestWidth = 10;
 
-  skia::RefPtr<SkCanvas> sk_canvas =
-      skia::AdoptRef(SkCanvas::NewRasterN32(300, 50));
+  skia::RefPtr<SkCanvas> sk_canvas = skia::AdoptRef(
+      SkCanvas::NewRasterN32(kCanvasSize.width(), kCanvasSize.height()));
   scoped_ptr<Canvas> canvas(
       Canvas::CreateCanvasWithoutScaling(sk_canvas.get(), 1.0f));
   scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
-  render_text->SetDisplayRect(Rect(300, 50));
+  render_text->SetDisplayRect(Rect(kCanvasSize));
   render_text->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   render_text->SetColor(SK_ColorBLACK);
 
-  for (size_t i = 0; i < arraysize(kTestStrings); ++i) {
+  for (auto string : kTestStrings) {
     sk_canvas->clear(SK_ColorWHITE);
-    render_text->SetText(WideToUTF16(kTestStrings[i]));
+    render_text->SetText(WideToUTF16(string));
     render_text->SetStyle(BOLD, true);
     render_text->Draw(canvas.get());
     int width = render_text->GetStringSize().width();
-    ASSERT_LT(width, 300);
+    ASSERT_GT(kCanvasSize.width() - kTestWidth, width);

[msw, 2014/12/12 18:58:43]

optional nit: this might be a bit clearer:
  ASSERT_LT(width + kTestWidth, kCanvasSize.width())

[ckocagil, 2014/12/12 22:16:23]

Done.

     const uint32* buffer = static_cast<const uint32*>(
         sk_canvas->peekPixels(NULL, NULL));
     ASSERT_NE(nullptr, buffer);
-    for (int y = 0; y < 50; ++y) {
-      EXPECT_EQ(SK_ColorWHITE, buffer[width + y * 300])
-          << "String: " << kTestStrings[i];
+
+    for (int y = 0; y < kCanvasSize.height(); ++y) {
+      for (int x = 0; x < kTestWidth; ++x) {

[msw, 2014/12/12 18:58:43]

optional nit: this might be a bit clearer:
  for (int y = 0; y < kCanvasSize.height(); ++y) {
    // Allow one column of anti-aliased pixels past the expected width.
    SkColor color = buffer[width + y * kCanvasSize.width()];
    EXPECT_LT(230U, color_utils::GetLuminanceForColor(color)) << string;
    for (int x = 1; x < kTestWidth; ++x) {
      color = buffer[width + x + y * kCanvasSize.width()];
      EXPECT_EQ(SK_ColorWHITE, color) << string;
    }
  }

[ckocagil, 2014/12/12 22:16:23]

Done.

+        const SkColor color = buffer[width + x + y * kCanvasSize.width()];
+        if (x == 0) {
+          // Allow one column of anti-aliased pixels past the expected width.
+          EXPECT_LT(230U, color_utils::GetLuminanceForColor(color))
+              << "String: " << string;
+          continue;
+        }
+        EXPECT_EQ(SK_ColorWHITE, color) << "String: " << string;
+      }
     }
   }
 }
 
 }  // namespace gfx