Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: ui/events/x/events_x_unittest.cc

Issue 785753002: Don't refcount tracking id -> slot id mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/x/events_x_unittest.cc
diff --git a/ui/events/x/events_x_unittest.cc b/ui/events/x/events_x_unittest.cc
index 065e804e39b6a71d5d35116a4bc34bffe998c630..a08974ab14e36fb3f3e5e771d6f7647df827c460 100644
--- a/ui/events/x/events_x_unittest.cc
+++ b/ui/events/x/events_x_unittest.cc
@@ -300,54 +300,47 @@ int GetTouchIdForTrackingId(uint32 tracking_id) {
return -1;
}
-TEST_F(EventsXTest, TouchEventIdRefcounting) {
+TEST_F(EventsXTest, TouchEventNotRemovingFromNativeMapping) {
std::vector<unsigned int> devices;
devices.push_back(0);
ui::SetUpTouchDevicesForTest(devices);
std::vector<Valuator> valuators;
- const int kTrackingId0 = 5;
- const int kTrackingId1 = 7;
+ const int kTrackingId = 5;
- // Increment ref count once for first touch.
+ // Two touch presses with the same tracking id.
ui::ScopedXI2Event xpress0;
xpress0.InitTouchEvent(
- 0, XI_TouchBegin, kTrackingId0, gfx::Point(10, 10), valuators);
+ 0, XI_TouchBegin, kTrackingId, gfx::Point(10, 10), valuators);
scoped_ptr<ui::TouchEvent> upress0(new ui::TouchEvent(xpress0));
- EXPECT_EQ(0, GetTouchIdForTrackingId(kTrackingId0));
+ EXPECT_EQ(0, GetTouchIdForTrackingId(kTrackingId));
- // Increment ref count 4 times for second touch.
ui::ScopedXI2Event xpress1;
xpress1.InitTouchEvent(
- 0, XI_TouchBegin, kTrackingId1, gfx::Point(20, 20), valuators);
+ 0, XI_TouchBegin, kTrackingId, gfx::Point(20, 20), valuators);
+ ui::TouchEvent upress1(xpress1);
+ EXPECT_EQ(0, GetTouchIdForTrackingId(kTrackingId));
- for (int i = 0; i < 4; ++i) {
- ui::TouchEvent upress1(xpress1);
- EXPECT_EQ(1, GetTouchIdForTrackingId(kTrackingId1));
+ // The first touch release shouldn't clear the mapping from the
+ // tracking id.
+ ui::ScopedXI2Event xrelease0;
+ xrelease0.InitTouchEvent(
+ 0, XI_TouchEnd, kTrackingId, gfx::Point(10, 10), valuators);
+ {
+ ui::TouchEvent urelease0(xrelease0);
+ urelease0.set_should_remove_native_touch_id_mapping(false);
}
+ EXPECT_EQ(0, GetTouchIdForTrackingId(kTrackingId));
+ // The second touch release should clear the mapping from the
+ // tracking id.
ui::ScopedXI2Event xrelease1;
xrelease1.InitTouchEvent(
- 0, XI_TouchEnd, kTrackingId1, gfx::Point(10, 10), valuators);
-
- // Decrement ref count 3 times for second touch.
- for (int i = 0; i < 3; ++i) {
+ 0, XI_TouchEnd, kTrackingId, gfx::Point(10, 10), valuators);
+ {
ui::TouchEvent urelease1(xrelease1);
- EXPECT_EQ(1, GetTouchIdForTrackingId(kTrackingId1));
}
-
- // This should clear the touch id of the second touch.
- scoped_ptr<ui::TouchEvent> urelease1(new ui::TouchEvent(xrelease1));
- urelease1.reset();
- EXPECT_EQ(-1, GetTouchIdForTrackingId(kTrackingId1));
-
- // This should clear the touch id of the first touch.
- ui::ScopedXI2Event xrelease0;
- xrelease0.InitTouchEvent(
- 0, XI_TouchEnd, kTrackingId0, gfx::Point(10, 10), valuators);
- scoped_ptr<ui::TouchEvent> urelease0(new ui::TouchEvent(xrelease0));
- urelease0.reset();
- EXPECT_EQ(-1, GetTouchIdForTrackingId(kTrackingId0));
+ EXPECT_EQ(-1, GetTouchIdForTrackingId(kTrackingId));
}
TEST_F(EventsXTest, NumpadKeyEvents) {

Powered by Google App Engine
This is Rietveld 408576698