Add new extension APIs related to animation policy.

chrome/browser/extensions/api/preference/preference_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/preference/preference_api.h"
 
 #include <map>
 #include <utility>
 
 #include "base/lazy_instance.h"
@@ skipping 51 matching lines @@
   // write permission should not be granted.
   APIPermission::ID write_permission;
 };
 
 const char kOnPrefChangeFormat[] = "types.ChromeSetting.%s.onChange";
 const char kConversionErrorMessage[] =
     "Internal error: Stored value for preference '*' cannot be converted "
     "properly.";
 
 PrefMappingEntry kPrefMapping[] = {
+    {"alternateErrorPagesEnabled",

[dmazzoni, 2015/01/27 06:52:41]

Thanks for sorting and reformatting these - but I think I'd be happier if you
split that into a separate change to land independently of this one.

The big worry is that if someone landed a small change to this code between when
you first wrote your patch and when you land it, it'd be easy to accidentally
overlook when merging.

[not at google - send to devlin, 2015/01/27 16:49:03]

Yes please.

If git cl format did this, then, let's figure something else out (but make sure
you rebase this CL + run gclient sync in case the clang-format rules have
changed; I've seen a lot of churn on enum declarations like this).

[je_julie(Not used), 2015/01/28 04:42:00]

I added new prefs without reformatting.
As to formatting, I'll consider it on another CL.

+     prefs::kAlternateErrorPagesEnabled,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
+    // accessibilityFeatures.animationPolicy is available for
+    // all platforms but the others from accessibilityFeatures
+    // is only avaiable for OS_CHROMEOS.
+    {"animationPolicy",
+     prefs::kAnimationPolicy,
+     APIPermission::kAccessibilityFeaturesRead,
+     APIPermission::kAccessibilityFeaturesModify},
+    {"autofillEnabled",
+     autofill::prefs::kAutofillEnabled,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
+    {"data_reduction.daily_original_length",
+     data_reduction_proxy::prefs::kDailyHttpOriginalContentLength,
+     APIPermission::kDataReductionProxy,
+     APIPermission::kDataReductionProxy},
+    {"data_reduction.daily_received_length",
+     data_reduction_proxy::prefs::kDailyHttpReceivedContentLength,
+     APIPermission::kDataReductionProxy,
+     APIPermission::kDataReductionProxy},
+    {"data_reduction.update_daily_lengths",
+     data_reduction_proxy::prefs::kUpdateDailyReceivedContentLengths,
+     APIPermission::kDataReductionProxy,
+     APIPermission::kDataReductionProxy},
+    {"hyperlinkAuditingEnabled",
+     prefs::kEnableHyperlinkAuditing,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
+    {"networkPredictionEnabled",
+     prefs::kNetworkPredictionOptions,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
+    {"passwordSavingEnabled",
+     password_manager::prefs::kPasswordManagerSavingEnabled,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
+    {"protectedContentEnabled",
+     prefs::kEnableDRM,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
+    {"proxy", prefs::kProxy, APIPermission::kProxy, APIPermission::kProxy},
+    {"referrersEnabled",
+     prefs::kEnableReferrers,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
+    {"safeBrowsingEnabled",
+     prefs::kSafeBrowsingEnabled,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
+    {"searchSuggestEnabled",
+     prefs::kSearchSuggestEnabled,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
     {"spdy_proxy.enabled",
      data_reduction_proxy::prefs::kDataReductionProxyEnabled,
-     APIPermission::kDataReductionProxy, APIPermission::kDataReductionProxy},
-    {"data_reduction.daily_original_length",
-     data_reduction_proxy::prefs::kDailyHttpOriginalContentLength,
-     APIPermission::kDataReductionProxy, APIPermission::kDataReductionProxy},
-    {"data_reduction.daily_received_length",
-     data_reduction_proxy::prefs::kDailyHttpReceivedContentLength,
-     APIPermission::kDataReductionProxy, APIPermission::kDataReductionProxy},
-    {"data_reduction.update_daily_lengths",
-     data_reduction_proxy::prefs::kUpdateDailyReceivedContentLengths,
-     APIPermission::kDataReductionProxy, APIPermission::kDataReductionProxy},
-    {"alternateErrorPagesEnabled", prefs::kAlternateErrorPagesEnabled,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
-    {"autofillEnabled", autofill::prefs::kAutofillEnabled,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
-    {"hyperlinkAuditingEnabled", prefs::kEnableHyperlinkAuditing,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
-    {"networkPredictionEnabled", prefs::kNetworkPredictionOptions,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
-    {"passwordSavingEnabled",
-     password_manager::prefs::kPasswordManagerSavingEnabled,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
-    {"protectedContentEnabled", prefs::kEnableDRM, APIPermission::kPrivacy,
+     APIPermission::kDataReductionProxy,
+     APIPermission::kDataReductionProxy},
+    {"spellingServiceEnabled",
+     prefs::kSpellCheckUseSpellingService,
+     APIPermission::kPrivacy,
      APIPermission::kPrivacy},
-    {"proxy", prefs::kProxy, APIPermission::kProxy, APIPermission::kProxy},
-    {"referrersEnabled", prefs::kEnableReferrers, APIPermission::kPrivacy,
+    {"thirdPartyCookiesAllowed",
+     prefs::kBlockThirdPartyCookies,
+     APIPermission::kPrivacy,
      APIPermission::kPrivacy},
-    {"safeBrowsingEnabled", prefs::kSafeBrowsingEnabled,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
-    {"searchSuggestEnabled", prefs::kSearchSuggestEnabled,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
-    {"spellingServiceEnabled", prefs::kSpellCheckUseSpellingService,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
-    {"thirdPartyCookiesAllowed", prefs::kBlockThirdPartyCookies,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
-    {"translationServiceEnabled", prefs::kEnableTranslate,
-     APIPermission::kPrivacy, APIPermission::kPrivacy},
+    {"translationServiceEnabled",
+     prefs::kEnableTranslate,
+     APIPermission::kPrivacy,
+     APIPermission::kPrivacy},
 #if defined(OS_CHROMEOS)
-    {"autoclick", prefs::kAccessibilityAutoclickEnabled,
+    {"autoclick",
+     prefs::kAccessibilityAutoclickEnabled,
      APIPermission::kAccessibilityFeaturesRead,
      APIPermission::kAccessibilityFeaturesModify},
-    {"highContrast", prefs::kAccessibilityHighContrastEnabled,
+    {"highContrast",
+     prefs::kAccessibilityHighContrastEnabled,
      APIPermission::kAccessibilityFeaturesRead,
      APIPermission::kAccessibilityFeaturesModify},
-    {"largeCursor", prefs::kAccessibilityLargeCursorEnabled,
+    {"largeCursor",
+     prefs::kAccessibilityLargeCursorEnabled,
      APIPermission::kAccessibilityFeaturesRead,
      APIPermission::kAccessibilityFeaturesModify},
-    {"screenMagnifier", prefs::kAccessibilityScreenMagnifierEnabled,
+    {"screenMagnifier",
+     prefs::kAccessibilityScreenMagnifierEnabled,
      APIPermission::kAccessibilityFeaturesRead,
      APIPermission::kAccessibilityFeaturesModify},
-    {"spokenFeedback", prefs::kAccessibilitySpokenFeedbackEnabled,
+    {"spokenFeedback",
+     prefs::kAccessibilitySpokenFeedbackEnabled,
      APIPermission::kAccessibilityFeaturesRead,
      APIPermission::kAccessibilityFeaturesModify},
-    {"stickyKeys", prefs::kAccessibilityStickyKeysEnabled,
+    {"stickyKeys",
+     prefs::kAccessibilityStickyKeysEnabled,
      APIPermission::kAccessibilityFeaturesRead,
      APIPermission::kAccessibilityFeaturesModify},
-    {"virtualKeyboard", prefs::kAccessibilityVirtualKeyboardEnabled,
+    {"virtualKeyboard",
+     prefs::kAccessibilityVirtualKeyboardEnabled,
      APIPermission::kAccessibilityFeaturesRead,
      APIPermission::kAccessibilityFeaturesModify},
 #endif
 };
 
 class IdentityPrefTransformer : public PrefTransformerInterface {
  public:
   base::Value* ExtensionToBrowserPref(const base::Value* extension_pref,
                                       std::string* error,
                                       bool* bad_message) override {
@@ skipping 612 matching lines @@
           pref_key, PreferenceFunction::PERMISSION_TYPE_WRITE, &browser_pref)) {
     return false;
   }
 
   PreferenceAPI::Get(GetProfile())
       ->RemoveExtensionControlledPref(extension_id(), browser_pref, scope);
   return true;
 }
 
 }  // namespace extensions