NewGC: Clean up a TODO. Make the empty string one of the

src/hydrogen-instructions.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2240 matching lines @@
 
   bool ImmortalImmovable() const {
     Heap* heap = HEAP;
     if (*handle_ == heap->undefined_value()) return true;
     if (*handle_ == heap->null_value()) return true;
     if (*handle_ == heap->true_value()) return true;
     if (*handle_ == heap->false_value()) return true;
     if (*handle_ == heap->the_hole_value()) return true;
     if (*handle_ == heap->minus_zero_value()) return true;
     if (*handle_ == heap->nan_value()) return true;
+    if (*handle_ == heap->empty_string()) return true;
     return false;
   }
 
   virtual Representation RequiredInputRepresentation(int index) const {
     return Representation::None();
   }
 
   virtual bool IsConvertibleToInteger() const {
     if (handle_->IsSmi()) return true;
     if (handle_->IsHeapNumber() &&
@@ skipping 1064 matching lines @@
     HLoadContextSlot* b = HLoadContextSlot::cast(other);
     return (slot_index() == b->slot_index());
   }
 
  private:
   int slot_index_;
 };
 
 
 static inline bool StoringValueNeedsWriteBarrier(HValue* value) {
-  // TODO(gc) On bleeding edge we omit write barrier when we are
-  // storing old space constant. We can't allow such an optimization
-  // on GC branch.
   return !value->type().IsBoolean()
       && !value->type().IsSmi()
       && !(value->IsConstant() && HConstant::cast(value)->ImmortalImmovable());
 }
 
 
 class HStoreContextSlot: public HTemplateInstruction<2> {
  public:
   HStoreContextSlot(HValue* context, int slot_index, HValue* value)
       : slot_index_(slot_index) {
@@ skipping 848 matching lines @@
 
   DECLARE_CONCRETE_INSTRUCTION(In)
 };
 
 #undef DECLARE_INSTRUCTION
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_INSTRUCTIONS_H_