Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 785693002: Adds DNS prefetch support to Chromecast. (Closed)

Created:
6 years ago by gunsch
Modified:
6 years ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@prefetch-browser
Project:
chromium
Visibility:
Public.

Description

Adds DNS prefetch support to Chromecast. R=lcwu@chromium.org,ttuttle@chromium.org BUG=419909 Committed: https://crrev.com/e49c69208e7da19a0b2a3ac9f2fd67d25c4a889e Cr-Commit-Position: refs/heads/master@{#307967}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : move PrescientNetworkingDispatcher implementation to components/dns_prefetch #

Patch Set 3 : rebase / gyp update #

Total comments: 2

Patch Set 4 : add blink dep to gyp/gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -74 lines) Patch
M chrome/chrome_renderer.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
D chrome/renderer/net/prescient_networking_dispatcher.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/renderer/net/prescient_networking_dispatcher.cc View 1 1 chunk +0 lines, -24 lines 0 comments Download
M chromecast/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chromecast/browser/url_request_context_factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/renderer/cast_content_renderer_client.h View 1 1 chunk +17 lines, -5 lines 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 1 4 chunks +15 lines, -0 lines 0 comments Download
M components/dns_prefetch.gypi View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/dns_prefetch/renderer/BUILD.gn View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M components/dns_prefetch/renderer/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
A + components/dns_prefetch/renderer/prescient_networking_dispatcher.h View 1 1 chunk +12 lines, -7 lines 0 comments Download
A + components/dns_prefetch/renderer/prescient_networking_dispatcher.cc View 1 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
gunsch
6 years ago (2014-12-06 00:47:16 UTC) #1
lcwu1
https://codereview.chromium.org/785693002/diff/20001/chromecast/browser/cast_content_browser_client.cc File chromecast/browser/cast_content_browser_client.cc (right): https://codereview.chromium.org/785693002/diff/20001/chromecast/browser/cast_content_browser_client.cc#newcode63 chromecast/browser/cast_content_browser_client.cc:63: url_request_context_factory_->host_resolver())); You will need to add net_message_filter to the ...
6 years ago (2014-12-06 02:01:33 UTC) #3
Deprecated (see juliatuttle)
https://codereview.chromium.org/785693002/diff/20001/chromecast/renderer/prescient_networking_dispatcher.h File chromecast/renderer/prescient_networking_dispatcher.h (left): https://codereview.chromium.org/785693002/diff/20001/chromecast/renderer/prescient_networking_dispatcher.h#oldcode12 chromecast/renderer/prescient_networking_dispatcher.h:12: class PrescientNetworkingDispatcher : public blink::WebPrescientNetworking { It looks like ...
6 years ago (2014-12-08 17:04:33 UTC) #4
gunsch
@jochen: PTAL for third_party/WebKit and chrome/. Both OWNERS requirements are due to moving chrome/renderer/net/PrescientNetworkingDispatcher to ...
6 years ago (2014-12-08 17:41:56 UTC) #6
lcwu1
lgtm on chromecast.
6 years ago (2014-12-08 22:47:17 UTC) #7
jochen (gone - plz use gerrit)
lgtm with comment addressed (for both gyp and gn) https://codereview.chromium.org/785693002/diff/60001/components/dns_prefetch.gypi File components/dns_prefetch.gypi (right): https://codereview.chromium.org/785693002/diff/60001/components/dns_prefetch.gypi#newcode55 components/dns_prefetch.gypi:55: ...
6 years ago (2014-12-09 15:56:05 UTC) #8
gunsch
https://codereview.chromium.org/785693002/diff/60001/components/dns_prefetch.gypi File components/dns_prefetch.gypi (right): https://codereview.chromium.org/785693002/diff/60001/components/dns_prefetch.gypi#newcode55 components/dns_prefetch.gypi:55: '../content/content.gyp:content_renderer', On 2014/12/09 15:56:04, jochen (slow) wrote: > also ...
6 years ago (2014-12-09 19:01:22 UTC) #9
gunsch
@ttuttle: ping? thanks
6 years ago (2014-12-11 18:10:12 UTC) #10
Deprecated (see juliatuttle)
On 2014/12/11 18:10:12, gunsch wrote: > @ttuttle: ping? thanks Oh, whoops. I made a comment ...
6 years ago (2014-12-11 18:42:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785693002/80001
6 years ago (2014-12-11 19:56:37 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:80001)
6 years ago (2014-12-11 20:54:38 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-11 20:55:21 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e49c69208e7da19a0b2a3ac9f2fd67d25c4a889e
Cr-Commit-Position: refs/heads/master@{#307967}

Powered by Google App Engine
This is Rietveld 408576698