easy-unlock: Turn on by default.

easy-unlock: Turn on by default.

- Turn on by default. Enabled flags are useless now but kept so that
  the CL introduces no string changes for about page and could be
  merged to M40.
- Policy is still respected to disable the feature;
- Disable flag takes precedence over policy;
- Remove finch check;

BUG=439583
Committed: https://crrev.com/4137c6348e8625747d027f37237d469078faef1c
Cr-Commit-Position: refs/heads/master@{#307146}

[xiyuan, 2014-12-05 23:13:26]

xiyuan@chromium.org changed reviewers:
+ isherman@chromium.org

[xiyuan, 2014-12-05 23:13:26]

Please take a look. Thanks.

[Ilya Sherman, 2014-12-05 23:22:07]

LGTM, thanks.

https://codereview.chromium.org/785663003/diff/1/chrome/browser/signin/easy_u...
File chrome/browser/signin/easy_unlock_service.cc (right):

https://codereview.chromium.org/785663003/diff/1/chrome/browser/signin/easy_u...
chrome/browser/signin/easy_unlock_service.cc:84:
proximity_auth::switches::kDisableEasySignin);
I wonder whether it's still worth having separate flags for unlock vs. sign-in,
or whether we should consolidate down to a single flag.

[xiyuan, 2014-12-06 00:34:17]

Patchset #2 (id:20001) has been deleted

[xiyuan, 2014-12-06 00:36:24]

CL also updated to fix tests.

https://codereview.chromium.org/785663003/diff/1/chrome/browser/signin/easy_u...
File chrome/browser/signin/easy_unlock_service.cc (right):

https://codereview.chromium.org/785663003/diff/1/chrome/browser/signin/easy_u...
chrome/browser/signin/easy_unlock_service.cc:84:
proximity_auth::switches::kDisableEasySignin);
On 2014/12/05 23:22:07, Ilya Sherman wrote:
> I wonder whether it's still worth having separate flags for unlock vs.
sign-in,
> or whether we should consolidate down to a single flag.

Makes sense.

But found that we had a bug (http://crbug.com/439638) that makes the non-owner
user not repsecting the flag. I'll keep two flags until the bug is fixed.

[Ilya Sherman, 2014-12-06 00:43:49]

Still LGTM, thanks.

[xiyuan, 2014-12-06 00:46:54]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-12-06 00:47:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/785663003/40001

[commit-bot: I haz the power, 2014-12-06 02:54:37]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2014-12-06 02:55:36]

Patchset 2 (id:??) landed as
https://crrev.com/4137c6348e8625747d027f37237d469078faef1c
Cr-Commit-Position: refs/heads/master@{#307146}