Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: media/mojo/services/media_renderer_apptest.cc

Issue 785643002: Pass mojo::MediaRendererPtr in MojoRendererImpl's constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_app
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/mojo/services/mojo_renderer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/media_renderer_apptest.cc
diff --git a/media/mojo/services/media_renderer_apptest.cc b/media/mojo/services/media_renderer_apptest.cc
index 5dac6e4173264b459156c1f20b76e4d66fdc7ab1..cc4deeef40fbefe3a5d1945c694a330a48504289 100644
--- a/media/mojo/services/media_renderer_apptest.cc
+++ b/media/mojo/services/media_renderer_apptest.cc
@@ -14,6 +14,7 @@
#include "mojo/public/cpp/application/application_delegate.h"
#include "mojo/public/cpp/application/application_impl.h"
#include "mojo/public/cpp/application/application_test_base.h"
+#include "mojo/public/cpp/application/connect.h"
namespace {
@@ -117,7 +118,13 @@ class MojoRendererTest : public mojo::test::ApplicationTestBase {
->GetServiceProvider();
}
- mojo::ServiceProvider* service_provider() { return service_provider_; }
+ mojo::MediaRendererPtr CreateMediaRenderer() {
+ mojo::MediaRendererPtr mojo_media_renderer;
+ mojo::ConnectToService(service_provider_,
+ &mojo_media_renderer);
+ return mojo_media_renderer.Pass();
+ }
+
DemuxerStreamProvider* stream_provider() {
return demuxer_stream_provider_.get();
}
@@ -142,7 +149,7 @@ void ErrorCallback(PipelineStatus* output, PipelineStatus status) {
// connection. The test also initializes a media::AudioRendererImpl which
// will error-out expectedly due to lack of support for decoder selection.
TEST_F(MojoRendererTest, BasicInitialize) {
- MojoRendererImpl mojo_renderer_impl(task_runner(), service_provider());
+ MojoRendererImpl mojo_renderer_impl(task_runner(), CreateMediaRenderer());
PipelineStatus expected_error(PIPELINE_OK);
mojo_renderer_impl.Initialize(
stream_provider(), base::MessageLoop::current()->QuitClosure(),
« no previous file with comments | « no previous file | media/mojo/services/mojo_renderer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698