runtime/vm/flow_graph_compiler_ia32.cc - Issue 785443002: Fix gc on MIPS (live registers were spilled in reversed order).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 785443002: Fix gc on MIPS (live registers were spilled in reversed order). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

===================================================================

--- runtime/vm/flow_graph_compiler_ia32.cc (revision 42124)

+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)

@@ -1470,7 +1470,8 @@

}

// Store general purpose registers with the highest register number at the

- // lowest address.

+ // lowest address. The order in which the registers are pushed must match the

+ // order in which the registers are encoded in the safe point's stack map.

for (intptr_t reg_idx = 0; reg_idx < kNumberOfCpuRegisters; ++reg_idx) {

if (locs->live_registers()->ContainsRegister(reg)) {

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | runtime/vm/flow_graph_compiler_mips.cc » ('J')