Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 785443002: Fix gc on MIPS (live registers were spilled in reversed order). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1427 matching lines...) Expand 10 before | Expand all | Expand 10 after
1438 for (intptr_t reg_idx = kNumberOfVRegisters - 1; 1438 for (intptr_t reg_idx = kNumberOfVRegisters - 1;
1439 reg_idx >= 0; --reg_idx) { 1439 reg_idx >= 0; --reg_idx) {
1440 VRegister fpu_reg = static_cast<VRegister>(reg_idx); 1440 VRegister fpu_reg = static_cast<VRegister>(reg_idx);
1441 if (locs->live_registers()->ContainsFpuRegister(fpu_reg)) { 1441 if (locs->live_registers()->ContainsFpuRegister(fpu_reg)) {
1442 __ PushQuad(fpu_reg); 1442 __ PushQuad(fpu_reg);
1443 } 1443 }
1444 } 1444 }
1445 } 1445 }
1446 1446
1447 // Store general purpose registers with the highest register number at the 1447 // Store general purpose registers with the highest register number at the
1448 // lowest address. 1448 // lowest address. The order in which the registers are pushed must match the
1449 // order in which the registers are encoded in the safe point's stack map.
1449 for (intptr_t reg_idx = 0; reg_idx < kNumberOfCpuRegisters; ++reg_idx) { 1450 for (intptr_t reg_idx = 0; reg_idx < kNumberOfCpuRegisters; ++reg_idx) {
1450 Register reg = static_cast<Register>(reg_idx); 1451 Register reg = static_cast<Register>(reg_idx);
1451 if (locs->live_registers()->ContainsRegister(reg)) { 1452 if (locs->live_registers()->ContainsRegister(reg)) {
1452 __ Push(reg); 1453 __ Push(reg);
1453 } 1454 }
1454 } 1455 }
1455 } 1456 }
1456 1457
1457 1458
1458 void FlowGraphCompiler::RestoreLiveRegisters(LocationSummary* locs) { 1459 void FlowGraphCompiler::RestoreLiveRegisters(LocationSummary* locs) {
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
1807 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) { 1808 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
1808 __ PopDouble(reg); 1809 __ PopDouble(reg);
1809 } 1810 }
1810 1811
1811 1812
1812 #undef __ 1813 #undef __
1813 1814
1814 } // namespace dart 1815 } // namespace dart
1815 1816
1816 #endif // defined TARGET_ARCH_ARM64 1817 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698