Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 785433003: Update upload.py in depot_tools to infra.git@3d174a0959ba68a4cd83a5abce9f497e30bfce68 (Closed)

Created:
6 years ago by iannucci
Modified:
6 years ago
Reviewers:
jrobbins, agable, M-A Ruel
CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@fix_broken
Project:
tools
Visibility:
Public.

Description

Update upload.py in depot_tools to infra.git@3d174a0959ba68a4cd83a5abce9f497e30bfce68 Includes fix for bug 388937. R=agable@chromium.org, jrobbins@chromium.org, maruel@chromium.org BUG=388937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -87 lines) Patch
M third_party/upload.py View 15 chunks +91 lines, -87 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
iannucci
6 years ago (2014-12-05 00:26:43 UTC) #1
agable
lgtm
6 years ago (2014-12-05 00:47:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785433003/1
6 years ago (2014-12-05 00:47:49 UTC) #4
commit-bot: I haz the power
Presubmit check for 785433003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-05 00:49:32 UTC) #6
iannucci
On 2014/12/05 00:49:32, I haz the power (commit-bot) wrote: > Presubmit check for 785433003-1 failed ...
6 years ago (2014-12-05 01:55:18 UTC) #7
iannucci
6 years ago (2014-12-05 02:06:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 293259.

Powered by Google App Engine
This is Rietveld 408576698