Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: experimental/PdfViewer/SkPdfFont.h

Issue 78543002: Add missing (trivial) virtual destructors. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/PdfViewer/SkPdfFont.h
diff --git a/experimental/PdfViewer/SkPdfFont.h b/experimental/PdfViewer/SkPdfFont.h
index 85ce6512d9bd2e4e2e08af6d3e2556ac74e222b2..71f98db2caf5b01cfc17541719028d5c2a87c7b0 100644
--- a/experimental/PdfViewer/SkPdfFont.h
+++ b/experimental/PdfViewer/SkPdfFont.h
@@ -77,6 +77,7 @@ public:
class SkPdfEncoding {
public:
+ virtual ~SkPdfEncoding() {}
virtual bool decodeText(const SkUnencodedText& textIn, SkDecodedText* textOut) const = 0;
static SkPdfEncoding* fromName(const char* name);
};
@@ -96,6 +97,7 @@ public:
class SkPdfIdentityHEncoding : public SkPdfEncoding {
public:
+ virtual ~SkPdfIdentityHEncoding() {}
virtual bool decodeText(const SkUnencodedText& textIn, SkDecodedText* textOut) const {
// TODO(edisonn): SkASSERT(textIn.len % 2 == 0); or report error?
@@ -119,6 +121,7 @@ public:
// TODO(edisonn): using this one when no encoding is specified
class SkPdfDefaultEncoding : public SkPdfEncoding {
public:
+ virtual ~SkPdfDefaultEncoding() {}
virtual bool decodeText(const SkUnencodedText& textIn, SkDecodedText* textOut) const {
// TODO(edisonn): SkASSERT(textIn.len % 2 == 0); or report error?
@@ -141,6 +144,7 @@ public:
class SkPdfCIDToGIDMapIdentityEncoding : public SkPdfEncoding {
public:
+ virtual ~SkPdfCIDToGIDMapIdentityEncoding() {}
virtual bool decodeText(const SkUnencodedText& textIn, SkDecodedText* textOut) const {
// TODO(edisonn): SkASSERT(textIn.len % 2 == 0); or report error?
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698