Issue 785313002: Fix id/class collection from stylesheets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 785313002: Fix id/class collection from stylesheets (Closed)

Created:
6 years ago by rafaelw

Modified:
6 years ago

Reviewers:
esprehn, ojan

CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix id/class collection from stylesheets BUG=438036 R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8f7fd967cfd0a5278d1b09660a386ca18f898eb5

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -3 lines)			Patch
M	sky/engine/core/css/RuleFeature.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A	sky/tests/lowlevel/bug-438036.sky	View	1 chunk	+29 lines, -0 lines	1 comment	Download
A	sky/tests/lowlevel/bug-438036-expected.txt	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rafaelw

Committed patchset #1 (id:1) manually as 8f7fd967cfd0a5278d1b09660a386ca18f898eb5 (presubmit successful).

6 years ago (2014-12-09 23:05:52 UTC) #4

ojan

6 years ago (2014-12-09 23:31:17 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/785313002/diff/1/sky/tests/lowlevel/bug-43803...
File sky/tests/lowlevel/bug-438036.sky (right):

https://codereview.chromium.org/785313002/diff/1/sky/tests/lowlevel/bug-43803...
sky/tests/lowlevel/bug-438036.sky:1: <sky>
I don't like this file naming scheme. It was always super annoying in WebKit.
Can you just give a descriptive name?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages