Function#toMethod: check `newHome` before `this`

test/mjsunit/harmony/toMethod.js

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Flags: --harmony-classes --allow-natives-syntax
 
 
 (function TestSingleClass() {
   function f(x) {
     var a = [0, 1, 2]
@@ skipping 28 matching lines @@
   assertEquals(5, q(1));
 }());
 
 
 (function TestErrorCases() {
   var sFun = Function.prototype.toMethod;
   assertThrows(function() { sFun.call({}); }, TypeError);
   assertThrows(function() { sFun.call({}, {}); }, TypeError);
   function f(){};
   assertThrows(function() { f.toMethod(1); }, TypeError);
+  try {
+    Function.prototype.toMethod.call(null, null);
+    // This must never be reached:
+    assertEquals(true, false);

[arv (Not doing code reviews), 2014/12/09 21:59:21]

assertUnreachable()

+  } catch (exception) {
+    assertTrue(exception instanceof TypeError);
+    assertEquals('Function.prototype.toMethod: home object null ' +
+      'is not an object', exception.message);

[arv (Not doing code reviews), 2014/12/09 21:59:20]

+2 indent

+  }
+  try {
+    Function.prototype.toMethod.call(42, null);
+    // This must never be reached:
+    assertEquals(true, false);
+  } catch (exception) {
+    assertTrue(exception instanceof TypeError);
+    assertEquals('Function.prototype.toMethod: home object null ' +
+      'is not an object', exception.message);
+  }
+  try {
+    Function.prototype.toMethod.call(42, {});
+    // This must never be reached:
+    assertEquals(true, false);
+  } catch (exception) {
+    assertTrue(exception instanceof TypeError);
+    assertEquals('Function.prototype.toMethod was called on 42, which is a ' +
+      'number and not a function', exception.message);
+  }

[mathiasb, 2014/12/09 21:59:11]

I’d love to use `assertThrows` here, but its optional third argument checks the
non-existent `exception.type` property rather than `exception.message`, and I
wasn’t sure if it would be okay to change this.

https://code.google.com/p/v8/source/browse/branches/bleeding_edge/test/mjsuni...

 }());
 
 
 (function TestPrototypeChain() {
   var o = {};
   var o1 = {};
   function f() { }
 
   function g() { }
 
@@ skipping 47 matching lines @@
   assertEquals("abc", g(o1));
 } ());
 
 (function TestExtensibility() {
   function f() {}
   Object.preventExtensions(f);
   assertFalse(Object.isExtensible(f));
   var m = f.toMethod({});
   assertTrue(Object.isExtensible(m));
 }());