Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 785303002: Function#toMethod: check `newHome` before `this` (Closed)

Created:
6 years ago by mathiasb
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Function#toMethod: check `newHome` before `this` `Function.prototype.toMethod` should check `newHome` before `this` as per the spec. V8 currently does it the other way around, resulting in the wrong error message being thrown. TEST=mjsunit/harmony BUG=v8:3749 LOG=Y

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated as per Erik’s feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M src/harmony-classes.js View 1 chunk +6 lines, -6 lines 0 comments Download
M test/mjsunit/harmony/toMethod.js View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mathiasb
PTAL
6 years ago (2014-12-09 21:56:22 UTC) #2
mathiasb
https://codereview.chromium.org/785303002/diff/1/test/mjsunit/harmony/toMethod.js File test/mjsunit/harmony/toMethod.js (right): https://codereview.chromium.org/785303002/diff/1/test/mjsunit/harmony/toMethod.js#newcode75 test/mjsunit/harmony/toMethod.js:75: } I’d love to use `assertThrows` here, but its ...
6 years ago (2014-12-09 21:59:11 UTC) #3
arv (Not doing code reviews)
LGTM with nits. https://codereview.chromium.org/785303002/diff/1/test/mjsunit/harmony/toMethod.js File test/mjsunit/harmony/toMethod.js (right): https://codereview.chromium.org/785303002/diff/1/test/mjsunit/harmony/toMethod.js#newcode52 test/mjsunit/harmony/toMethod.js:52: assertEquals(true, false); assertUnreachable() https://codereview.chromium.org/785303002/diff/1/test/mjsunit/harmony/toMethod.js#newcode56 test/mjsunit/harmony/toMethod.js:56: 'is ...
6 years ago (2014-12-09 21:59:21 UTC) #4
Dmitry Lomov (no reviews)
6 years ago (2014-12-09 22:14:19 UTC) #6
let's not land until https://bugs.ecmascript.org/show_bug.cgi?id=3430 is
resolved, but thanks for tha patch

Powered by Google App Engine
This is Rietveld 408576698