Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 785233008: MacViews: Use views::TestViewsDelegate in ViewEventTestBase (Closed)

Created:
6 years ago by tapted
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Use views::TestViewsDelegate in ViewEventTestBase It currently uses ChromeViewsDelegate. This is a problem for MacViews, because ChromeViewsDelegate only provides an out-of-process compositor, which isn't available in tests using ViewEventTestBase. It's not a problem for Aura, because Aura platforms tend to get their ContextFactory form aura::Env instead of ViewsDelegate BUG=403679 Committed: https://crrev.com/10749b7552af6e163ebcf5aa4992a4af03fdba3e Cr-Commit-Position: refs/heads/master@{#307996}

Patch Set 1 : Let's see what breaks... #

Patch Set 2 : needs set_use_desktop_native_widgets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/test/base/view_event_test_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tapted
Hi sky, PTAL
6 years ago (2014-12-11 07:51:13 UTC) #2
sky
LGTM
6 years ago (2014-12-11 15:37:26 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-11 23:13:39 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-11 23:14:49 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10749b7552af6e163ebcf5aa4992a4af03fdba3e
Cr-Commit-Position: refs/heads/master@{#307996}

Powered by Google App Engine
This is Rietveld 408576698