Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 785233007: Switch ChromeShellActivity to extend ActionBarActivity. (Closed)

Created:
6 years ago by aurimas (slooooooooow)
Modified:
6 years ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch ChromeShellActivity to extend ActionBarActivity. We should have changed this when we switched to AppCompat theme. BUG=None R=tedchoc@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/66030761eb9590a13344bd89c74cd138c89d2b7d

Patch Set 1 #

Patch Set 2 : Fix GN, maybe #

Patch Set 3 : Fix GN again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/android/BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
aurimas (slooooooooow)
tedchoc: PTAL
6 years ago (2014-12-11 00:07:46 UTC) #2
Ted C
lgtm
6 years ago (2014-12-12 22:42:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785233007/1
6 years ago (2014-12-12 22:44:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/25730)
6 years ago (2014-12-13 00:11:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785233007/20001
6 years ago (2014-12-13 00:34:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/25764) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/42521)
6 years ago (2014-12-13 02:01:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785233007/40001
6 years ago (2014-12-15 18:34:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/18428)
6 years ago (2014-12-15 20:28:13 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/66030761eb9590a13344bd89c74cd138c89d2b7d Cr-Commit-Position: refs/heads/master@{#308411}
6 years ago (2014-12-15 20:51:05 UTC) #16
aurimas (slooooooooow)
6 years ago (2014-12-15 20:51:10 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
66030761eb9590a13344bd89c74cd138c89d2b7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698