chrome/browser/signin/signin_global_error.cc - Issue 785233002: Enable chrome.gyp:browser on iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_global_error.cc

Issue 785233002: Enable chrome.gyp:browser on iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comment Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/signin_global_error.cc

diff --git a/chrome/browser/signin/signin_global_error.cc b/chrome/browser/signin/signin_global_error.cc

index 2c98019561c04273d21b0a15ef75f06db4cf6d4b..5f1174fc6e0b9c792d276babd3ce0ce99160e995 100644

--- a/chrome/browser/signin/signin_global_error.cc

+++ b/chrome/browser/signin/signin_global_error.cc

@@ -93,8 +93,8 @@ void SigninGlobalError::ExecuteMenuItem(Browser* browser) {

}

#endif

- // Global errors don't show up in the wrench menu on android.

-#if !defined(OS_ANDROID)

+ // Global errors don't show up in the wrench menu on mobile.

+#if !defined(OS_ANDROID) && !defined(OS_IOS)

LoginUIService* login_ui = LoginUIServiceFactory::GetForProfile(profile_);

if (login_ui->current_login_ui()) {

login_ui->current_login_ui()->FocusUI();