[Android] Add a check function for intent fallback navigation

[Android] Add a check function for intent fallback navigation

BUG=440178
Committed: https://crrev.com/d00c9171cc8f35caba93bf89705abe9884375583
Cr-Commit-Position: refs/heads/master@{#308480}

[Changwan Ryu, 2014-12-09 07:31:31]

changwan@chromium.org changed reviewers:
+ dfalcantara@chromium.org, jaekyun@chromium.org, mariakhomenko@chromium.org,
tedchoc@chromium.org

[gone, 2014-12-09 17:41:01]

dfalcantara@chromium.org changed reviewers:
+ palmer@chromium.org

[gone, 2014-12-09 17:41:01]

+Palmer for the initial OK.

[Maria, 2014-12-09 18:47:20]

lgtm

[palmer, 2014-12-09 22:04:26]

LGTM. Thanks!

https://codereview.chromium.org/785163002/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java
(right):

https://codereview.chromium.org/785163002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java:81: public
static boolean isValidForIntentFallbackNavigation(String uri) {
Arguably, *this* method's caller should do new URI(...). In general, my
inclination is to push strong typing up and up and up to higher layers of the
API.

But as written this is not wrong, so my comment is just a nit.

[Changwan Ryu, 2014-12-10 01:39:31]

On 2014/12/09 22:04:26, Chromium Palmer wrote:
> LGTM. Thanks!
> 
>
https://codereview.chromium.org/785163002/diff/1/chrome/android/java/src/org/...
> File chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java
> (right):
> 
>
https://codereview.chromium.org/785163002/diff/1/chrome/android/java/src/org/...
> chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java:81:
public
> static boolean isValidForIntentFallbackNavigation(String uri) {
> Arguably, *this* method's caller should do new URI(...). In general, my
> inclination is to push strong typing up and up and up to higher layers of the
> API.
> 
> But as written this is not wrong, so my comment is just a nit.

I still need owner approval.
Ted, could you take a look?

[gone, 2014-12-10 02:34:25]

lgtm on my end too

[Changwan Ryu, 2014-12-11 23:08:39]

tedchoc@: Please review UrlUtilities.java. Thanks!

[Ted C, 2014-12-15 23:48:05]

lgtm

[Changwan Ryu, 2014-12-15 23:50:08]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2014-12-15 23:50:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/785163002/1

[commit-bot: I haz the power, 2014-12-16 00:54:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-16 00:56:23]

Patchset 1 (id:??) landed as
https://crrev.com/d00c9171cc8f35caba93bf89705abe9884375583
Cr-Commit-Position: refs/heads/master@{#308480}