Issue 7850003: Fixed sync re-activation when the device comes online after offline login.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7850003: Fixed sync re-activation when the device comes online after offline login. (Closed)

Created:
9 years, 3 months ago by zel

Modified:
9 years, 3 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, nkostylev+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed sync re-activation when the device comes online after offline login. BUG=chromium-os:19844 TEST=make sure that about:sync shows functional sync engine after we come back online after offline login Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100059

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -1 line)			Patch
M	chrome/browser/chromeos/login/login_utils.cc	View	1	7 chunks	+31 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

xiyuan

9 years, 3 months ago (2011-09-07 23:25:48 UTC) #2

LGTM

http://codereview.chromium.org/7850003/diff/1/chrome/browser/chromeos/login/l...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/7850003/diff/1/chrome/browser/chromeos/login/l...
chrome/browser/chromeos/login/login_utils.cc:362: virtual void
OnOnlineStateChanged(bool online);
nit: OVERRIDE

Expand Messages | Collapse Messages