Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 784873004: Push API: delete MockWebPushClient [switchover 2/6] (Closed)

Created:
6 years ago by Michael van Ouwerkerk
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Push API: delete MockWebPushClient [switchover 2/6] This functionality is being replaced by LayoutTestPushMessagingService. Depends on https://codereview.chromium.org/735293005/ (Push API: delete the old layout tests.) This part 2 of a series of 6 patches. See https://crbug.com/440076 for the plan to land them. BUG=389194, 440076 Committed: https://crrev.com/e29f55713b967c860305caff2184940c4d3312c8 Cr-Commit-Position: refs/heads/master@{#307911}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -193 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/mock_web_push_client.h View 1 chunk +0 lines, -53 lines 0 comments Download
D content/shell/renderer/test_runner/mock_web_push_client.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 5 chunks +0 lines, -31 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 5 chunks +0 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
6 years ago (2014-12-08 20:03:34 UTC) #2
Peter Beverloo
On 2014/12/08 20:03:34, Michael van Ouwerkerk wrote: > Peter, could you take a look please? ...
6 years ago (2014-12-08 20:43:48 UTC) #3
Michael van Ouwerkerk
Mike, could you take a look as content/shell owner please?
6 years ago (2014-12-09 12:33:24 UTC) #5
Mike West
yay deleting things. LGTM.
6 years ago (2014-12-09 12:37:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/784873004/20001
6 years ago (2014-12-11 15:36:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-11 16:38:24 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-11 16:39:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e29f55713b967c860305caff2184940c4d3312c8
Cr-Commit-Position: refs/heads/master@{#307911}

Powered by Google App Engine
This is Rietveld 408576698