[Cronet] Implement methods to get response headers in HttpURLConnection.

components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java

Index: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java
index 289fb8975cbabe04fcce34ffd82933fed5b8be3b..ff0b1b0c9c2583637edfedc2ddfe3abdb699217b 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java
@@ -602,6 +602,112 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
         connection.disconnect();
     }
 
+    @SmallTest
+    @Feature({"Cronet"})
+    @CompareDefaultWithCronet
+    public void testGetResponseHeadersAsMap() throws Exception {
+        URL url = new URL(UploadTestServer.getFileURL("/success.txt"));
+        HttpURLConnection connection =
+                (HttpURLConnection) url.openConnection();
+        Map<String, List<String>> responseHeaders =
+                connection.getHeaderFields();
+        // Make sure response header map is not modifiable.
+        try {
+            responseHeaders.put("foo", Arrays.asList("v1", "v2"));
+            fail();
+        } catch (Exception e) {

[miloslav, 2015/01/20 15:25:10]

Maybe the more specific UnsupportedOperationException is more appropriate (so
that it's not e.g. NPE).

Also below.

[xunjieli, 2015/01/20 16:12:21]

Done.

+            // Expected.
+        }
+        List<String> contentType = responseHeaders.get("Content-type");
+        // Make sure map value is not modifiable as well.
+        try {
+            contentType.add("v3");
+            fail();
+        } catch (Exception e) {
+            // Expected.
+        }
+        // Make sure map look up is key insensitive.
+        List<String> contentTypeWithOddCase =
+                responseHeaders.get("ContENt-tYpe");
+        assertEquals(contentType, contentTypeWithOddCase);
+
+        assertEquals(1, contentType.size());
+        assertEquals("text/plain", contentType.get(0));
+        List<String> accessControl =
+                responseHeaders.get("Access-Control-Allow-Origin");
+        assertEquals(1, accessControl.size());
+        assertEquals("*", accessControl.get(0));
+        List<String> singleHeader = responseHeaders.get("header-name");
+        assertEquals(1, singleHeader.size());
+        assertEquals("header-value", singleHeader.get(0));
+        List<String> multiHeader = responseHeaders.get("multi-header-name");
+        assertEquals(2, multiHeader.size());
+        assertEquals("header-value1", multiHeader.get(0));
+        assertEquals("header-value2", multiHeader.get(1));
+        connection.disconnect();
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @CompareDefaultWithCronet
+    public void testGetResponseHeaderField() throws Exception {
+        URL url = new URL(UploadTestServer.getFileURL("/success.txt"));
+        HttpURLConnection connection =
+                (HttpURLConnection) url.openConnection();
+        assertEquals("text/plain", connection.getHeaderField("Content-Type"));
+        assertEquals("*",
+                connection.getHeaderField("Access-Control-Allow-Origin"));
+        assertEquals("header-value", connection.getHeaderField("header-name"));
+        // If there are multiple headers with the same name, the last should be
+        // returned.
+        assertEquals("header-value2",
+                connection.getHeaderField("multi-header-name"));
+        // Lastly, make sure lookup is case-insensitive.
+        assertEquals("header-value2",
+                connection.getHeaderField("MUlTi-heAder-name"));
+        connection.disconnect();
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @CompareDefaultWithCronet
+    public void testGetResponseHeaderFieldWithPos() throws Exception {
+        URL url = new URL(UploadTestServer.getFileURL("/success.txt"));
+        HttpURLConnection connection =
+                (HttpURLConnection) url.openConnection();
+        assertEquals("Content-Type", connection.getHeaderFieldKey(0));
+        assertEquals("text/plain", connection.getHeaderField(0));
+        assertEquals("Access-Control-Allow-Origin",
+                connection.getHeaderFieldKey(1));
+        assertEquals("*", connection.getHeaderField(1));
+        assertEquals("header-name", connection.getHeaderFieldKey(2));
+        assertEquals("header-value", connection.getHeaderField(2));
+        assertEquals("multi-header-name", connection.getHeaderFieldKey(3));
+        assertEquals("header-value1", connection.getHeaderField(3));
+        assertEquals("multi-header-name", connection.getHeaderFieldKey(4));
+        assertEquals("header-value2", connection.getHeaderField(4));
+        // Note that the default implementation also adds additional response
+        // headers, which are not tested here.
+        connection.disconnect();
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @OnlyRunCronetHttpURLConnection
+    // The default implementation adds additional response headers, so this test
+    // only tests Cronet's implementation.
+    public void testGetResponseHeaderFieldWithPosExceed() throws Exception {
+        URL url = new URL(UploadTestServer.getFileURL("/success.txt"));
+        HttpURLConnection connection =
+                (HttpURLConnection) url.openConnection();
+        // Expect null if we exceed the number of header entries.
+        assertEquals(null, connection.getHeaderFieldKey(5));
+        assertEquals(null, connection.getHeaderField(5));
+        assertEquals(null, connection.getHeaderFieldKey(6));
+        assertEquals(null, connection.getHeaderField(6));
+        connection.disconnect();
+    }
+
     private void checkExceptionsAreThrown(HttpURLConnection connection)
             throws Exception {
         try {
@@ -632,6 +738,11 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
             // Expected.
         }
 
+        // Skip getHeaderFields(), since it can return null or an empty map.
+        assertNull(connection.getHeaderField("foo"));
+        assertNull(connection.getHeaderFieldKey(0));
+        assertNull(connection.getHeaderField(0));
+
         // getErrorStream() does not have a throw clause, it returns null if
         // there's an exception.
         InputStream errorStream = connection.getErrorStream();