Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java

Issue 784853004: [Cronet] Implement methods to get response headers in HttpURLConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
index c6e6c2cb4a8151fe21c3245cc569425c62e25437..716e16806e9445bbc452ac372fb3f19ce080a59c 100644
--- a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
@@ -13,9 +13,9 @@ import org.chromium.base.JNINamespace;
import java.nio.ByteBuffer;
import java.util.ArrayList;
import java.util.Collections;
-import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.TreeMap;
import java.util.concurrent.Executor;
/**
@@ -117,6 +117,7 @@ final class CronetUrlRequest implements UrlRequest {
private final HeadersList mAllHeaders = new HeadersList();
private final boolean mWasCached;
private final String mNegotiatedProtocol;
+ private Map<String, List<String>> mResponseHeaders;
NativeResponseInfo(String[] urlChain, int httpStatusCode,
String httpStatusText, boolean wasCached,
@@ -155,17 +156,21 @@ final class CronetUrlRequest implements UrlRequest {
@Override
public Map<String, List<String>> getAllHeaders() {
- Map<String, List<String>> map = new HashMap<String, List<String>>();
+ if (mResponseHeaders != null) {
+ return mResponseHeaders;
+ }
+ Map<String, List<String>> map = new TreeMap<String, List<String>>(
+ String.CASE_INSENSITIVE_ORDER);
for (Pair<String, String> entry : mAllHeaders) {
+ List<String> values = new ArrayList<String>();
if (map.containsKey(entry.first)) {
miloslav 2015/01/20 15:25:10 There is no null key containing the status line an
xunjieli 2015/01/20 16:12:21 Yes, you are right. There is no null key support.
mef 2015/01/30 16:22:51 I think that's a right thing for CronetUrlRequest,
- map.get(entry.first).add(entry.second);
- } else {
- List<String> values = new ArrayList<String>();
- values.add(entry.second);
- map.put(entry.first, values);
+ values.addAll(map.get(entry.first));
}
+ values.add(entry.second);
+ map.put(entry.first, Collections.unmodifiableList(values));
}
- return Collections.unmodifiableMap(map);
+ mResponseHeaders = Collections.unmodifiableMap(map);
+ return mResponseHeaders;
}
@Override

Powered by Google App Engine
This is Rietveld 408576698