Remove filtering of analyzer warnings/errors by filename

dart/tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 294 matching lines @@
         super._equal(other) &&
         browser == other.browser &&
         url == other.url &&
         checkedMode == other.checkedMode;
   }
 }
 
 class AnalysisCommand extends Command {
   final String flavor;
 
-  // If [fileFilter] is given, only errors/warnings reported by the analyzer
-  // for which [fileFilter] returns [:true:] are considered.
-  final Function fileFilter;
-
   AnalysisCommand._(this.flavor,
                     String displayName,
                     String executable,
                     List<String> arguments,
-                    String configurationDir,
-                    this.fileFilter)
+                    String configurationDir)
       : super._(displayName, executable, arguments, configurationDir);
 
   void _buildHashCode(HashCodeBuilder builder) {
     super._buildHashCode(builder);
     builder.add(flavor);
-    builder.add(fileFilter);
   }
 
   bool _equal(Command other) {
     return
         other is AnalysisCommand &&
         super._equal(other) &&
-        flavor == other.flavor &&
-        fileFilter == other.fileFilter;
+        flavor == other.flavor;
   }
 }
 
 class VmCommand extends Command {
   VmCommand._(String executable,
               List<String> arguments,
               String configurationDir)
       : super._("vm", executable, arguments, configurationDir);
 }
 
@@ skipping 48 matching lines @@
                                            String configurationDir) {
     var command =
         new CompilationCommand._(displayName, outputFile, neverSkipCompilation,
                                  bootstrapDependencies, executable, arguments,
                                  configurationDir);
     return _getUniqueCommand(command);
   }
 
   AnalysisCommand getAnalysisCommand(
       String displayName, executable, arguments, String configurationDir,
-      {String flavor: 'dartanalyzer', Function fileFilter: null}) {
+      {String flavor: 'dartanalyzer'}) {
     var command = new AnalysisCommand._(
-        flavor, displayName, executable, arguments, configurationDir,
-        fileFilter);
+        flavor, displayName, executable, arguments, configurationDir);
     return _getUniqueCommand(command);
   }
 
   VmCommand getVmCommand(String executable,
                          List<String> arguments,
                          String configurationDir) {
     var command = new VmCommand._(executable, arguments, configurationDir);
     return _getUniqueCommand(command);
   }
 
@@ skipping 732 matching lines @@
     }
 
     assert (errors.length == 0 && warnings.length == 0);
     assert (!testCase.info.hasCompileError &&
             !testCase.info.hasStaticWarning);
     return Expectation.PASS;
   }
 
   void parseAnalyzerOutput(List<String> outErrors, List<String> outWarnings) {
     AnalysisCommand analysisCommand = command;
-    Function fileFilter = analysisCommand.fileFilter;
-    if (fileFilter == null) {
-      // If no filter function was given, we don't filter the output at all.
-      fileFilter = (arg) => true;
-    }
 
     // Parse a line delimited by the | character using \ as an escape charager
     // like:  FOO|BAR|FOO\|BAR|FOO\\BAZ as 4 fields: FOO BAR FOO|BAR FOO\BAZ
     List<String> splitMachineError(String line) {
       StringBuffer field = new StringBuffer();
       List<String> result = [];
       bool escaped = false;
       for (var i = 0 ; i < line.length; i++) {
         var c = line[i];
         if (!escaped && c == '\\') {
@@ skipping 10 matching lines @@
       }
       result.add(field.toString());
       return result;
     }
 
     for (String line in decodeUtf8(super.stderr).split("\n")) {
       if (line.length == 0) continue;
       List<String> fields = splitMachineError(line);
       // We only consider errors/warnings for files of interest.
       if (fields.length > FILENAME) {
-        if (fileFilter(fields[FILENAME])) {
-          if (fields[ERROR_LEVEL] == 'ERROR') {
-            outErrors.add(fields[FORMATTED_ERROR]);
-          } else if (fields[ERROR_LEVEL] == 'WARNING') {
-            outWarnings.add(fields[FORMATTED_ERROR]);
-          }
+        if (fields[ERROR_LEVEL] == 'ERROR') {
+          outErrors.add(fields[FORMATTED_ERROR]);
+        } else if (fields[ERROR_LEVEL] == 'WARNING') {
+          outWarnings.add(fields[FORMATTED_ERROR]);
         }
         // OK to Skip error output that doesn't match the machine format
       }
     }
   }
 }
 
 class VmCommandOutputImpl extends CommandOutputImpl
                           with UnittestSuiteMessagesMixin {
   static const DART_VM_EXITCODE_COMPILE_TIME_ERROR = 254;
@@ skipping 1196 matching lines @@
     }
   }
 
   void eventAllTestsDone() {
     for (var listener in _eventListener) {
       listener.allDone();
     }
     _allDone();
   }
 }