Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.cc

Issue 784823002: Pass through the CONVERT/NONCONVERT/HANKAKU_ZENKAKU keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/input_method_manager_impl.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
index f9fd914af14100ab3da32fbbee758df7e7ee97a4..085034f33ff545e501c0bdb66406c2ddc2f7bb66 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
@@ -741,7 +741,12 @@ bool InputMethodManagerImpl::StateImpl::SwitchInputMethod(
}
SwitchToNextInputMethodInternal(ids, current_input_method.id());
- return true; // consume the accelerator.
+
+ // Consume if the triggering accelerator key may have a side-effect(unexpected
+ // character insertion or unexpected accelerator triggering). Here all
+ // incoming key code is only CONVERT/NONCONVERT/HANKAKU_ZENKAKU keys. Thus no
+ // need to consume keys since none of them have side-effect.
+ return false;
Shu Chen 2014/12/08 14:55:07 you may need to rebase this cl.
Seigo Nonaka 2014/12/09 09:27:32 Oh... the HEAD is quite different...
}
void InputMethodManagerImpl::StateImpl::SwitchToNextInputMethodInternal(
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698