Issue 7847002: Removed unneeded cairo code.

Issue 7847002: Removed unneeded cairo code. (Closed)

Created:
9 years, 3 months ago by Albert Bodenhamer

Modified:
9 years, 3 months ago

Reviewers:
vandebo (ex-Chrome), commit-bot: I haz the power, reed1

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove dead cairo code. BUG= TEST=No visible changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100281

Patch Set 2 : Removed unneeded include #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1265 lines)			Patch
M	printing/metafile_impl.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
D	printing/pdf_metafile_cairo_linux.h	View		1 chunk	+0 lines, -88 lines	0 comments	Download
D	printing/pdf_metafile_cairo_linux.cc	View		1 chunk	+0 lines, -259 lines	0 comments	Download
D	printing/pdf_metafile_cairo_linux_unittest.cc	View		1 chunk	+0 lines, -85 lines	0 comments	Download
M	printing/printing.gyp	View		2 chunks	+0 lines, -3 lines	0 comments	Download
D	skia/ext/vector_platform_device_cairo_linux.h	View		1 chunk	+0 lines, -131 lines	0 comments	Download
D	skia/ext/vector_platform_device_cairo_linux.cc	View		1 chunk	+0 lines, -695 lines	0 comments	Download
M	skia/skia.gyp	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

LGTM http://codereview.chromium.org/7847002/diff/1/printing/metafile_impl.h File printing/metafile_impl.h (right): http://codereview.chromium.org/7847002/diff/1/printing/metafile_impl.h#newcode13 printing/metafile_impl.h:13: #include "printing/pdf_metafile_skia.h" nit: I think line 17 covers ...

9 years, 3 months ago (2011-09-07 22:26:48 UTC) #2

Albert Bodenhamer

http://codereview.chromium.org/7847002/diff/1/printing/metafile_impl.h File printing/metafile_impl.h (right): http://codereview.chromium.org/7847002/diff/1/printing/metafile_impl.h#newcode13 printing/metafile_impl.h:13: #include "printing/pdf_metafile_skia.h" On 2011/09/07 22:26:48, vandebo wrote: > nit: ...

9 years, 3 months ago (2011-09-07 23:10:38 UTC) #4

Change committed as 100281

Expand Messages | Collapse Messages