Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 784653002: Revert of Make ui::Compositor use ui::Scheduler (Closed)

Created:
6 years ago by Ilya Sherman
Modified:
6 years ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dcheng, enne (OOO), jbauman+watch_chromium.org, kalyank, piman, piman+watch_chromium.org, sievers+watch_chromium.org, tfarina, Ian Vollick, brianderson, mithro
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ui::Compositor use ui::Scheduler (patchset #13 id:360001 of https://codereview.chromium.org/638653003/) Reason for revert: This appears to be causing crashes on the Windows perf bots. See the linked bug for a stack trace. BUG=439649 Original issue's description: > Make ui::Compositor use ui::Scheduler > > Taken from enne's CL 535733002 and rebased. It has been taken out of CL 134623005. > > BUG=329552 > > Committed: https://crrev.com/36b7fc7f8b05ea627873e58a162c1c26784e472d > Cr-Commit-Position: refs/heads/master@{#298779} > > Committed: https://crrev.com/b821b71ff0166e250ae4b30b56c1b7b6d3bd5db6 > Cr-Commit-Position: refs/heads/master@{#306954} TBR=ben@chromium.org,danakj@chromium.org,piman@chromium.org,sky@chromium.org,weiliangc@chromium.org NOTREECHECKS=true NOTRY=true BUG=329552 Committed: https://crrev.com/4f0404e167031301c3f877e8000f5423b9adb9b7 Cr-Commit-Position: refs/heads/master@{#307132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -142 lines) Patch
M cc/trees/single_thread_proxy.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/menu_view_drag_and_drop_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/compositor/test/no_transport_image_transport_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/compositor/compositor.h View 5 chunks +22 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 9 chunks +96 lines, -24 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 8 chunks +11 lines, -19 lines 0 comments Download
M ui/compositor/test/context_factories_for_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.h View 2 chunks +3 lines, -12 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_ozone.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_x11.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/examples/examples_main.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/view_unittest.cc View 14 chunks +20 lines, -40 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
Created Revert of Make ui::Compositor use ui::Scheduler
6 years ago (2014-12-06 01:00:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/784653002/1
6 years ago (2014-12-06 01:00:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-06 01:01:52 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-06 01:02:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f0404e167031301c3f877e8000f5423b9adb9b7
Cr-Commit-Position: refs/heads/master@{#307132}

Powered by Google App Engine
This is Rietveld 408576698