Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2200)

Unified Diff: pkg/analyzer/lib/src/generated/source_io.dart

Issue 784623004: Remove old instrumentation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/scanner.dart ('k') | pkg/analyzer/test/enum_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/source_io.dart
diff --git a/pkg/analyzer/lib/src/generated/source_io.dart b/pkg/analyzer/lib/src/generated/source_io.dart
index 4918519736b54c3d5faab54470c1072a2a8c09da..58aee2498df05d15d00f7cc7e1f07cfe1fcf04bd 100644
--- a/pkg/analyzer/lib/src/generated/source_io.dart
+++ b/pkg/analyzer/lib/src/generated/source_io.dart
@@ -8,7 +8,6 @@
library engine.source.io;
import 'engine.dart';
-import 'instrumentation.dart';
import 'java_core.dart';
import 'java_engine.dart';
import 'java_io.dart';
@@ -236,16 +235,17 @@ class FileBasedSource implements Source {
* Record the time the IO took if it was slow
*/
void _reportIfSlowIO(int nanos) {
- //If slower than 10ms
- if (nanos > 10 * TimeCounter.NANOS_PER_MILLI) {
- InstrumentationBuilder builder = Instrumentation.builder2("SlowIO");
- try {
- builder.data3("fileName", fullName);
- builder.metric2("IO-Time-Nanos", nanos);
- } finally {
- builder.log();
- }
- }
+ // TODO(brianwilkerson) Decide whether we still want to capture this data.
+// //If slower than 10ms
+// if (nanos > 10 * TimeCounter.NANOS_PER_MILLI) {
+// InstrumentationBuilder builder = Instrumentation.builder2("SlowIO");
+// try {
+// builder.data3("fileName", fullName);
+// builder.metric2("IO-Time-Nanos", nanos);
+// } finally {
+// builder.log();
+// }
+// }
}
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/scanner.dart ('k') | pkg/analyzer/test/enum_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698