Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(58)

Issue 7846013: Merge 94721 - FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoade... (Closed)

Created:
9 years, 1 month ago by abarth-chromium
Modified:
9 years, 1 month ago
Reviewers:
abarth
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94721 - FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader::detachFromParent https://bugs.webkit.org/show_bug.cgi?id=61810 Reviewed by Eric Seidel. Fix this crash as suggested by Darin Fisher in https://bugs.webkit.org/show_bug.cgi?id=61810#c21. This patch does not include the test requested by Alexey Proskuryakov in https://bugs.webkit.org/show_bug.cgi?id=61810#c6. I would really much rather include a test with this patch, but my attempts to write a test have failed. :( * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): TBR=abarth@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/WebKit/chromium/src/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
abarth-chromium
9 years, 1 month ago (2011-09-08 07:29:02 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698