Add histograms to track how long QUIC read/write operations take to complete.

Add histograms to track how long QUIC read/write operations take to complete.

BUG=439522
Committed: https://crrev.com/d885a6855fb022b204f4cfb33cec73a71bd889f3
Cr-Commit-Position: refs/heads/master@{#307097}

[Ryan Hamilton, 2014-12-05 19:01:36]

rch@chromium.org changed reviewers:
+ asvitkine@chromium.org, rtenneti@chromium.org

[Ryan Hamilton, 2014-12-05 19:01:36]

I got this presubmit warning, but I think it's spurious:

Some UMA_HISTOGRAM lines have been modified and the associated histogram name
has no match in either metrics/histograms.xml or the modifications of it:
   [net/quic/quic_default_packet_writer.cc:58491]
Net.QuicSession.PacketWriteTime.Synchronous \
   [net/quic/quic_default_packet_writer.cc:58491]
Net.QuicSession.PacketWriteTime.Asynchronous

[Ryan Hamilton, 2014-12-05 19:03:40]

rch@chromium.org changed reviewers:
+ ianswett@google.com

[Ryan Hamilton, 2014-12-05 19:03:41]

ianswett: FYI

[ramant (doing other things), 2014-12-05 20:05:24]

LGTM. Please consider fixing nits.

https://codereview.chromium.org/784563002/diff/1/net/quic/quic_client_session.cc
File net/quic/quic_client_session.cc (right):

https://codereview.chromium.org/784563002/diff/1/net/quic/quic_client_session...
net/quic/quic_client_session.cc:764:
UMA_HISTOGRAM_BOOLEAN("Net.QuicSession.AyncRead", rv == ERR_IO_PENDING);
nit: AyncRead -> AsyncRead

https://codereview.chromium.org/784563002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/784563002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:17727: +<histogram
name="Net.QuicSession.AyncRead">
nit: AyncRead -> AsyncRead

https://codereview.chromium.org/784563002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:17730: +    True of the result of
reading a packet from the network was ERR_IO_PENDING.
nit: Should "True of" be "True if". I am not good at this.

[Ryan Hamilton, 2014-12-05 20:23:09]

Thanks!

https://codereview.chromium.org/784563002/diff/1/net/quic/quic_client_session.cc
File net/quic/quic_client_session.cc (right):

https://codereview.chromium.org/784563002/diff/1/net/quic/quic_client_session...
net/quic/quic_client_session.cc:764:
UMA_HISTOGRAM_BOOLEAN("Net.QuicSession.AyncRead", rv == ERR_IO_PENDING);
On 2014/12/05 20:05:24, ramant wrote:
> nit: AyncRead -> AsyncRead

Done.

https://codereview.chromium.org/784563002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/784563002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:17727: +<histogram
name="Net.QuicSession.AyncRead">
On 2014/12/05 20:05:24, ramant wrote:
> nit: AyncRead -> AsyncRead

Done.

https://codereview.chromium.org/784563002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:17730: +    True of the result of
reading a packet from the network was ERR_IO_PENDING.
On 2014/12/05 20:05:24, ramant wrote:
> nit: Should "True of" be "True if". I am not good at this.

Done.

[Alexei Svitkine (slow), 2014-12-05 20:26:43]

lgtm

[Ryan Hamilton, 2014-12-05 20:27:12]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-12-05 20:28:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/784563002/20001

[commit-bot: I haz the power, 2014-12-05 22:22:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-05 22:24:56]

Patchset 2 (id:??) landed as
https://crrev.com/d885a6855fb022b204f4cfb33cec73a71bd889f3
Cr-Commit-Position: refs/heads/master@{#307097}