Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 784553004: Revert of Generalize V4L2 HW video codec device names (Closed)

Created:
6 years ago by jonross
Modified:
6 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, jln+watch_chromium.org, wiley, bshe, dharani1, jrbarnette, ilja, Jorge Lucangeli Obes, scherkus (not reviewing), henryhsu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Generalize V4L2 HW video codec device names (patchset #1 id:1 of https://codereview.chromium.org/730693005/) Reason for revert: This change breaks video_ChromeHWDecodeUsed, please see crbug.com/439175 for details. Original issue's description: > Generalize V4L2 HW video codec device names > > Switch to more generalized V4L2 video accelerator device names and update > sandbox rules to reflect that. > > This is another attempt at crrev.com/763743002, reverted in > crrev.com/767383002 with a fixup for sandbox permissions. > > BUG=405861, 437598 > TEST=compile > > Committed: https://crrev.com/30a3721c82953428d445a93ebe2bf0014e27bc10 > Cr-Commit-Position: refs/heads/master@{#306642} TBR=jorgelo@chromium.org,scherkus@chromium.org,posciak@chromium.org NOTREECHECKS=true NOTRY=true BUG=405861, 437598 Committed: https://crrev.com/8286b103de0dbc30bc0ab2012fd26fce8b683f90 Cr-Commit-Position: refs/heads/master@{#307077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -283 lines) Patch
A content/common/gpu/media/exynos_v4l2_video_device.h View 1 chunk +58 lines, -0 lines 0 comments Download
A content/common/gpu/media/exynos_v4l2_video_device.cc View 1 chunk +211 lines, -0 lines 0 comments Download
D content/common/gpu/media/generic_v4l2_video_device.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/common/gpu/media/generic_v4l2_video_device.cc View 1 chunk +0 lines, -211 lines 0 comments Download
M content/common/gpu/media/v4l2_video_device.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jonross
Created Revert of Generalize V4L2 HW video codec device names
6 years ago (2014-12-05 20:53:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/784553004/1
6 years ago (2014-12-05 20:54:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 20:55:31 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-05 20:56:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8286b103de0dbc30bc0ab2012fd26fce8b683f90
Cr-Commit-Position: refs/heads/master@{#307077}

Powered by Google App Engine
This is Rietveld 408576698