Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 78453005: Move PolicySchema and PolicySchemaRegistry to components/policy/. (Closed)

Created:
7 years, 1 month ago by dconnelly
Modified:
7 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Joao da Silva
Visibility:
Public.

Description

Move PolicySchema and PolicySchemaRegistry to components/policy/. This facilitates the refactoring of chrome/browser/policy into a layered component. Depends on https://codereview.chromium.org/78823004/ BUG=271392 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236785

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : export nested class on win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1065 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/proxy_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/async_policy_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/async_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/async_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/browser_policy_connector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/forwarding_policy_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/forwarding_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/mock_configuration_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/schema_map.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/policy/schema_map.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/policy/schema_map_unittest.cc View 1 chunk +0 lines, -313 lines 0 comments Download
D chrome/browser/policy/schema_registry.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/policy/schema_registry.cc View 1 chunk +0 lines, -175 lines 0 comments Download
M chrome/browser/policy/schema_registry_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/schema_registry_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/schema_registry_unittest.cc View 1 chunk +0 lines, -242 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
A + components/policy/core/common/schema_map.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/schema_map.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/schema_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/schema_registry.h View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
A + components/policy/core/common/schema_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/schema_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dconnelly
7 years, 1 month ago (2013-11-20 18:50:49 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/78453005/diff/1/components/policy/core/common/schema_map.h File components/policy/core/common/schema_map.h (right): https://codereview.chromium.org/78453005/diff/1/components/policy/core/common/schema_map.h#newcode25 components/policy/core/common/schema_map.h:25: class POLICY_EXPORT SchemaMap : public base::RefCountedThreadSafe<SchemaMap> { should ...
7 years, 1 month ago (2013-11-21 13:45:48 UTC) #2
dconnelly
https://codereview.chromium.org/78453005/diff/1/components/policy/core/common/schema_map.h File components/policy/core/common/schema_map.h (right): https://codereview.chromium.org/78453005/diff/1/components/policy/core/common/schema_map.h#newcode25 components/policy/core/common/schema_map.h:25: class POLICY_EXPORT SchemaMap : public base::RefCountedThreadSafe<SchemaMap> { On 2013/11/21 ...
7 years, 1 month ago (2013-11-22 13:18:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/78453005/180001
7 years, 1 month ago (2013-11-22 15:03:59 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 17:50:50 UTC) #5
Message was sent while issue was closed. 
Change committed as 236785

Powered by Google App Engine
This is Rietveld 408576698