Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 78453002: Reland r17907 - Make it possible to add more than one piece of embedder data to isolates" (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Reland r17907 - Make it possible to add more than one piece of embedder data to isolates" This will allow for using gin and blink bindings in the same process. Over r17907, I changed the order of fields in Isolate to be stable across different platforms, since the ABI defined packing is not the same on all targets, and I initialize the embedder data field in Isolate. BUG=317398 R=svenpanne@chromium.org, dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=17935

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -30 lines) Patch
M include/v8.h View 1 5 chunks +53 lines, -11 lines 0 comments Download
M src/d8.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/isolate.h View 1 2 chunks +10 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +22 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-20 13:32:23 UTC) #1
Sven Panne
lgtm
7 years, 1 month ago (2013-11-20 13:54:29 UTC) #2
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-20 15:16:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r17935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698